[PR #3] [MERGED] Fix 3 remaining bugs found in third review pass #2

New issue

Closed

opened 2026-03-13 13:04:21 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 13:04:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/291-Group/LAN-Orangutan/pull/3
Author: @FileBay
Created: 12/31/2025
Status: ✅ Merged
Merged: 12/31/2025
Merged by: @FileBay

Base: main ← Head: claude/audit-code-bugs-NaPWC

📝 Commits (1)

b3e475f Fix 3 remaining bugs found in third review pass

📊 Changes

3 files changed (+17 additions, -4 deletions)

View changed files

📝 scanner/utils.py (+7 -1)
📝 web/assets/app.js (+4 -1)
📝 web/settings.php (+6 -2)

📄 Description

Fix critical bug: deleteDevice() missing Content-Type header causing CSRF check to reject all DELETE requests (would fail silently)
Fix port range validation to reject invalid ports (>65535) and ensure start <= end
Add defensive check for malformed IPs in detect_networks() to prevent potential IndexError/ValueError crashes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/291-Group/LAN-Orangutan/pull/3 **Author:** [@FileBay](https://github.com/FileBay) **Created:** 12/31/2025 **Status:** ✅ Merged **Merged:** 12/31/2025 **Merged by:** [@FileBay](https://github.com/FileBay) **Base:** `main` ← **Head:** `claude/audit-code-bugs-NaPWC` --- ### 📝 Commits (1) - [`b3e475f`](https://github.com/291-Group/LAN-Orangutan/commit/b3e475fcc5258276ecaa55d01b3f72292d6c9e53) Fix 3 remaining bugs found in third review pass ### 📊 Changes **3 files changed** (+17 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `scanner/utils.py` (+7 -1) 📝 `web/assets/app.js` (+4 -1) 📝 `web/settings.php` (+6 -2) </details> ### 📄 Description - Fix critical bug: deleteDevice() missing Content-Type header causing CSRF check to reject all DELETE requests (would fail silently) - Fix port range validation to reject invalid ports (>65535) and ensure start <= end - Add defensive check for malformed IPs in detect_networks() to prevent potential IndexError/ValueError crashes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>