[PR #10] [CLOSED] fix: resolve 7 bugs across codebase #10

Closed
opened 2026-03-01 14:51:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/atiilla/GeoIntel/pull/10
Author: @PierrunoYT
Created: 2/27/2026
Status: Closed

Base: mainHead: fix/bug-analysis-clean


📝 Commits (1)

  • 12c30ca fix: resolve 7 bugs across codebase

📊 Changes

6 files changed (+130 additions, -21 deletions)

View changed files

BUG_REPORT.md (+51 -0)
📝 geointel/api_client.py (+8 -3)
📝 geointel/config.py (+2 -1)
📝 geointel/geointel.py (+3 -2)
📝 geointel/image_processor.py (+64 -13)
📝 requirements.txt (+2 -2)

📄 Description

Summary

Clean PR with a single commit based on the current upstream main. Fixes 7 bugs found in the codebase.

Critical / High

  1. MIME type always defaults to JPEG — process_image() did not detect or return MIME type, so PNG/WebP/GIF images were always sent to Gemini as image/jpeg
  2. No content-type validation for URL downloads — download_image() accepted any HTTP response (HTML, JSON, etc.) without checking Content-Type
  3. API key could leak in error messages — raw response.text was logged and raised in exceptions on HTTP errors

Medium

  1. No image size limit — no size check before loading images into memory (added 20 MB limit)
  2. API timeout too short — increased from 30s to 60s for Gemini vision requests
  3. HTTP error message lost context — download errors now include status code and URL
  4. requirements.txt missing version constraints — added flask and flask-cors version pins to match setup.py

See BUG_REPORT.md for full details.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/atiilla/GeoIntel/pull/10 **Author:** [@PierrunoYT](https://github.com/PierrunoYT) **Created:** 2/27/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/bug-analysis-clean` --- ### 📝 Commits (1) - [`12c30ca`](https://github.com/atiilla/GeoIntel/commit/12c30ca137c604ad3c8751e4a1c0fae5df660c43) fix: resolve 7 bugs across codebase ### 📊 Changes **6 files changed** (+130 additions, -21 deletions) <details> <summary>View changed files</summary> ➕ `BUG_REPORT.md` (+51 -0) 📝 `geointel/api_client.py` (+8 -3) 📝 `geointel/config.py` (+2 -1) 📝 `geointel/geointel.py` (+3 -2) 📝 `geointel/image_processor.py` (+64 -13) 📝 `requirements.txt` (+2 -2) </details> ### 📄 Description ## Summary Clean PR with a single commit based on the current upstream main. Fixes 7 bugs found in the codebase. ### Critical / High 1. **MIME type always defaults to JPEG** — process_image() did not detect or return MIME type, so PNG/WebP/GIF images were always sent to Gemini as image/jpeg 2. **No content-type validation for URL downloads** — download_image() accepted any HTTP response (HTML, JSON, etc.) without checking Content-Type 3. **API key could leak in error messages** — raw response.text was logged and raised in exceptions on HTTP errors ### Medium 4. **No image size limit** — no size check before loading images into memory (added 20 MB limit) 5. **API timeout too short** — increased from 30s to 60s for Gemini vision requests 6. **HTTP error message lost context** — download errors now include status code and URL 7. **requirements.txt missing version constraints** — added flask and flask-cors version pins to match setup.py See BUG_REPORT.md for full details. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem changed title from [PR #10] fix: resolve 7 bugs across codebase to [PR #10] [CLOSED] fix: resolve 7 bugs across codebase 2026-03-15 11:26:30 +03:00
kerem closed this issue 2026-03-15 11:26:45 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/GeoIntel#10
No description provided.