mirror of
https://github.com/KelvinTegelaar/CIPP.git
synced 2026-04-25 16:26:09 +03:00
[GH-ISSUE #1615] New CIPP user invite script doesnt work #871
Labels
No labels
API
Feature
NotABug
NotABug
Planned
Sponsor Priority
Sponsor Priority
bug
documentation
duplicate
enhancement
needs more info
no-activity
no-priority
not-assigned
pull-request
react-conversion
react-conversion
roadmap
security
stale
unconfirmed-by-user
unconfirmed-by-user
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/CIPP#871
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MBstatsara on GitHub (Jul 10, 2023).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/1615
Originally assigned to: @MBstatsara on GitHub.
Description
Go to settings, click maintenance select add-cippuser.ps1
This doesnt work unless a custom domain is valid, i have edited the script and tested at my end and it works with the default domain if the value in the script is null.
Environment data
@github-actions[bot] commented on GitHub (Jul 10, 2023):
Thank you for creating a bug. Please make sure your bug is indeed a unique case by checking current and past issues, and reading the complete documentation at https://docs.cipp.app/
If your bug is a known documentation issue, it will be closed without notice by a contributor. To confirm that this is not a bug found in the documentation, please copy and paste the following comment: "I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.".
Without confirming, your report will be closed in 24 hours. If you'd like this bug to be assigned to you, please comment "I would like to work on this please!".
@MBstatsara commented on GitHub (Jul 10, 2023):
I would like to work on this please
@MBstatsara commented on GitHub (Jul 10, 2023):
Simply adding the last line to ExecMaintenanceScripts/Scripts/Add-CippUser.ps1
Fixes the problem
$swa = Get-AzStaticWebApp -ResourceGroupName $ResourceGroup
$Domain = $swa.CustomDomain | Select-Object -First 1
if ($Domain -eq $null){$Domain = $swa.DefaultHostname}
@MBstatsara commented on GitHub (Jul 10, 2023):
I would like to work on this please!
@github-actions[bot] commented on GitHub (Jul 10, 2023):
Great! I assigned you (@MBstatsara) to the issue. Have fun working on it!
@MBstatsara commented on GitHub (Jul 10, 2023):
Also adding line
$SelectedUsers = $AllUsers | Where-Object { $CurrentUsers.DisplayName -notcontains $_.UserPrincipalName } | sort-Object -Property DisplayName | Out-ConsoleGridView -Title "Select users for role '$Role'"
sorts the name by users name instead of random orders and makes it much easier to add users.
@KelvinTegelaar commented on GitHub (Jul 19, 2023):
Fixed in dev. :)