mirror of
https://github.com/KelvinTegelaar/CIPP.git
synced 2026-04-25 08:16:01 +03:00
[GH-ISSUE #2955] [Feature Request]: Add permission classification #1468
Labels
No labels
API
Feature
NotABug
NotABug
Planned
Sponsor Priority
Sponsor Priority
bug
documentation
duplicate
enhancement
needs more info
no-activity
no-priority
not-assigned
pull-request
react-conversion
react-conversion
roadmap
security
stale
unconfirmed-by-user
unconfirmed-by-user
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/CIPP#1468
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @alexrsagen on GitHub (Oct 25, 2024).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/2955
Description of the new feature - must be an in-depth explanation of the feature you want, reasoning why, and the added benefits for MSPs as a whole.
The standard "Allow users to consent to applications with low security risk (Prevent OAuth phishing. Lower impact, less secure.)" was added in
github.com/KelvinTegelaar/CIPP@3e58a79873,github.com/KelvinTegelaar/CIPP-API@86210c60c6to fulfill feature request #1685.Assigning the default role permission grant policies
["ManagePermissionGrantsForSelf.microsoft-user-default-low"], without classifying any permissions as low risk, is equivalent to not assigning any policies at all[](which is what the "Do not allow user consent" setting in Entra ID does).Adding to #1685, I'd like to request the option to specify which permissions to classify as "low risk" when enabling this standard in CIPP. This makes the entire standard easier to use, by automating the classification of permissions across tenants.
The following permissions are the most requested application permissions with low-risk access, according to Microsoft.
User.Read- sign in and read user profileoffline_access- maintain access to data that users have given it access toopenid- sign users inprofile- view user's basic profileemail- view user's email addressThe list of permissions to classify as low risk could be specified in a similar matter as the "Allowed application IDs" for the standard "Require admin consent for applications (Prevent OAuth phishing)". It would be nice if the most requested permissions with low-risk access was a default (but modifyable) value.
I work for an MSP and we're trying to deploy this standard, but we're now realizing that no permissions get classified when deploying it. We're having to either roll back the standard or automate the permission classification with Microsoft Graph ourselves.
PowerShell commands you would normally use to achieve above request
Get-MgServicePrincipalGet-MgServicePrincipalDelegatedPermissionClassificationNew-MgServicePrincipalDelegatedPermissionClassificationUpdate-MgServicePrincipalDelegatedPermissionClassificationRemove-MgServicePrincipalDelegatedPermissionClassificationList servicePrincipalsGET /servicePrincipals?$filter=hasPermissionClassifications%20eq%20true&$expand=delegatedPermissionClassificationList delegatedPermissionClassifications collection of servicePrincipalCreate delegatedPermissionClassificationDelete delegatedPermissionClassification@KelvinTegelaar commented on GitHub (Oct 25, 2024):
Only sponsors can create feature requests
@OfficialEsco commented on GitHub (Oct 25, 2024):
Can it reopen if i request this? 👀
@KelvinTegelaar commented on GitHub (Oct 25, 2024):
Appreciate you jumping in here, and we totally get where you’re coming from. But allowing sponsors to re-request closed ideas from non-sponsors kind of goes against the spirit of our system.
The goal behind limiting requests to paying users is to keep things fair, focused, and impactful for everyone supporting CIPP directly. When requests get re-submitted this way, it can open the door to a flood of indirect requests that might not have the same priority or backing, or financially impacts us to a point where we will be forced to make a choice to make CIPP a paid application only.
When a sponsor makes a request they directly pay for training our helpdesk, the actual development time we spend to develop a feature, the time we spend documenting the feature and for any security audits we'll have to perform. If sponsors would reopen requests for non-sponsors there would be no reason for anyone to pay, as they can just find another paying user. This would eventually on a longer term lead to situations where we'd just wont be able to operate anymore. Our system helps keep this sustainable :)
That being said; as you are also an active contributor you could implement this, or ask the submitter to try to implement it himself. We accept any PR that involves good code. :)
It’s not about turning down good ideas—just keeping the pipeline manageable so we can keep delivering meaningful updates and improvements for you and all our sponsors. Hope that makes sense, and thanks for understanding!
@alexrsagen commented on GitHub (Oct 25, 2024):
Hi @KelvinTegelaar, thanks for the quick response.
We (@Konsept-IT) are now a sponsor, please re-open 😄
@KelvinTegelaar commented on GitHub (Oct 25, 2024):
Done!
@github-actions[bot] commented on GitHub (Nov 4, 2024):
This issue is stale because it has been open 10 days with no activity. We will close this issue soon. If you want this feature implemented you can contribute it. See: https://docs.cipp.app/dev-documentation/contributing-to-the-code . Please notify the team if you are working on this yourself.
@github-actions[bot] commented on GitHub (Nov 18, 2024):
This issue was closed because it has been stalled for 14 days with no activity.