mirror of
https://github.com/KelvinTegelaar/CIPP.git
synced 2026-04-25 16:26:09 +03:00
[GH-ISSUE #2114] [Feature Request]: Add impersonation protection toggles to new and offboarding users #1078
Labels
No labels
API
Feature
NotABug
NotABug
Planned
Sponsor Priority
Sponsor Priority
bug
documentation
duplicate
enhancement
needs more info
no-activity
no-priority
not-assigned
pull-request
react-conversion
react-conversion
roadmap
security
stale
unconfirmed-by-user
unconfirmed-by-user
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/CIPP#1078
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @SMRITServices on GitHub (Feb 7, 2024).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/2114
Description of the new feature - must be an in-depth explanation of the feature you want, reasoning why, and the added benefits for MSPs as a whole.
When adding a new user, a toggle that subsequently adds the new user to the impersonation protection policy after the user is created
When offboarding a user via the wizard, a toggle that subsequently removes the user from the impersonation protection policy during the offboarding process
You can add a drop down in the respective form to select which policy(s) to add/remove the user from
When adding or offboarding a user, a proper setup should include adding or removing that user to/from impersonation protection, with this toggle, it is one less standard operating procedure that needs to be done outside of CIPP. Adding this feature will also make it easier for MSP's to get started using impersonation protection if they are not already.
PowerShell commands you would normally use to achieve above request
DefineUser
Get list of polices
DefinePolicy (Let user select Policy(s) from list of polices gathered in $Policies using $Policies[#].Identity as the display varibale)
Add user to policy
Remove user from policy
To make the removal more robust, a search can be performed on a policy through the $_.TargetedUsersToProtect to confirm the user is there prior to removal
The above search should rely on the users UPN and not the whole "$(`$DisplayName);$($UPN)" variable due to the fact that someone can manually change the display name of the user when adding them to impersonation protection, but they cannot modify the UPN. Then you remove them based on that variable in the event that the display name is different than the office 365 display name.
@KelvinTegelaar commented on GitHub (Feb 7, 2024):
You must be a sponsor to create an fr