starred/BoostNote-App

Fork 0

mirror of https://github.com/BoostIO/BoostNote-App.git synced 2026-04-26 21:05:55 +03:00

[PR #394] [CLOSED] Hotkey Implementation #740

New issue

Closed

opened 2026-03-03 00:22:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:22:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/394
Author: @oakypokey
Created: 3/29/2020
Status: ❌ Closed

Base: master ← Head: Hotkeys

📝 Commits (9)

0e228bc Added Keybinding tab skele
fe41a2d Created Keybinding grid and added en-US
855c749 kinda getting there: simple testing for hooks
61e1726 playing with state management
1783d46 Completed recording and preference saving
3400038 Added keycoder for key name management
8a768c1 Added error checking
46cf0de linting and cleaning
2d4e2a0 made it so options are gernerated from pref file

📊 Changes

7 files changed (+255 additions, -7 deletions)

View changed files

📝 package-lock.json (+7 -2)
📝 package.json (+1 -0)
➕ src/components/PreferencesModal/KeyBindingTab.tsx (+195 -0)
📝 src/components/PreferencesModal/PreferencesModal.tsx (+9 -5)
📝 src/lib/preferences.ts (+28 -0)
📝 src/locales/enUS.ts (+14 -0)
➕ typings/keycoder.d.ts (+1 -0)

📄 Description

Issue #367

Description

Added a tab called 'Keybindings' in the preferences pane that allows the user to record shortcuts to use in BoostNote. This new set of preferences is stored in the same place as the existing preferences.

Screenshots

Testing

Ubuntu Electron App: There's some weird behavior the occurs because shortcuts aren't de-registered or paused when trying to set the new keybinding. This should be addressed during implementation of the shortcut execution

Web App: Working | No issues here because the browser doesn't pick up on these actions though it is still important to pause hotkey actions when preferences are in focus

Is there a way that BoostNote manages hotkeys using electron? I'm unfamiliar with electron so any guidance would be appreciated :) I'm also not sure if it falls under the scope of the issue?

This is my first PR so any feedback on how to improve, please let me know!

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

#367: Customizable hotkey system

IssueHunt has been backed by the following sponsors. Become a sponsor

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/394 **Author:** [@oakypokey](https://github.com/oakypokey) **Created:** 3/29/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `Hotkeys` --- ### 📝 Commits (9) - [`0e228bc`](https://github.com/BoostIO/BoostNote-App/commit/0e228bc2d83bbd91739f24434e0cdf97ee4c43ee) Added Keybinding tab skele - [`fe41a2d`](https://github.com/BoostIO/BoostNote-App/commit/fe41a2dfdc507e829e3619877086ffd353a36615) Created Keybinding grid and added en-US - [`855c749`](https://github.com/BoostIO/BoostNote-App/commit/855c74900e5a27f8a5d28567f0cfab46b587a55a) kinda getting there: simple testing for hooks - [`61e1726`](https://github.com/BoostIO/BoostNote-App/commit/61e1726727a8d91ac17dce9effec084bb3351c9d) playing with state management - [`1783d46`](https://github.com/BoostIO/BoostNote-App/commit/1783d46d932750f1db14067d5f52c0d852f9be6a) Completed recording and preference saving - [`3400038`](https://github.com/BoostIO/BoostNote-App/commit/3400038d99bc6bca322caa706b234bde78acec9e) Added keycoder for key name management - [`8a768c1`](https://github.com/BoostIO/BoostNote-App/commit/8a768c1b5fcfe7a63d640a40dae8d1210a74e82c) Added error checking - [`46cf0de`](https://github.com/BoostIO/BoostNote-App/commit/46cf0de86710ac1d7d3f58aac2da9575ccb070e9) linting and cleaning - [`2d4e2a0`](https://github.com/BoostIO/BoostNote-App/commit/2d4e2a0353de325dd01d668201c3cdc220e53c51) made it so options are gernerated from pref file ### 📊 Changes **7 files changed** (+255 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `package-lock.json` (+7 -2) 📝 `package.json` (+1 -0) ➕ `src/components/PreferencesModal/KeyBindingTab.tsx` (+195 -0) 📝 `src/components/PreferencesModal/PreferencesModal.tsx` (+9 -5) 📝 `src/lib/preferences.ts` (+28 -0) 📝 `src/locales/enUS.ts` (+14 -0) ➕ `typings/keycoder.d.ts` (+1 -0) </details> ### 📄 Description Issue #367 # Description Added a tab called 'Keybindings' in the preferences pane that allows the user to record shortcuts to use in BoostNote. This new set of preferences is stored in the same place as the existing preferences. # Screenshots ![image](https://user-images.githubusercontent.com/18006562/77852803-8c480600-71ae-11ea-9430-58a435e0d558.png) ![image](https://user-images.githubusercontent.com/18006562/77853741-c1a32280-71b3-11ea-823d-357113bcbc47.png) # Testing Ubuntu Electron App: There's some weird behavior the occurs because shortcuts aren't de-registered or paused when trying to set the new keybinding. This should be addressed during implementation of the shortcut execution Web App: Working | No issues here because the browser doesn't pick up on these actions though it is still important to pause hotkey actions when preferences are in focus Is there a way that BoostNote manages hotkeys using electron? I'm unfamiliar with electron so any guidance would be appreciated :) I'm also not sure if it falls under the scope of the issue? _This is my first PR so any feedback on how to improve, please let me know!_  --- <details> <summary> <b>IssueHunt Summary</b> </summary> ### Referenced issues This pull request has been submitted to: - [#367: Customizable hotkey system](https://issuehunt.io/repos/74213528/issues/367) --- IssueHunt has been backed by the following sponsors. [Become a sponsor](https://issuehunt.io/membership/members) </details>  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 00:22:59 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/BoostNote-App#740

No description provided.

Rows
Columns