[GH-ISSUE #762] Improve local editor search (consistency with global search and improvements) #394

Closed
opened 2026-03-03 00:20:49 +03:00 by kerem · 1 comment
Owner

Originally created by @Komediruzecki on GitHub (Jan 9, 2021).
Original GitHub issue: https://github.com/BoostIO/BoostNote-App/issues/762

Originally assigned to: @Komediruzecki on GitHub.

When exporting a note as an HTML file or a markdown file, assets used in the note should be exported too.

Current behavior

  • Local editor search is using codemirror embedded search functionality.
  • Local editor search has bad shortcuts bound to it
  • Local editor search has hard to use search/replace process
  • Local editor search is inconsistent with global content search

Expected behavior

  • Local editor search should use the same search functionality as global search (just scoped to current note and/or title)

  • Local editor search should have proper shortcuts bound to it

    • ctrl+f search/find text
    • ctrl+r search and replace
  • Local editor search should have double search bars (one for search and one for replacing at top of the editor)

  • Local editor search should use newly implemented global search algorithms (searching, highlighting, and marking text in codemirror)

Implementation Details

  • There should be a component that consists of search input

    • This component should feature various options at the end of search input (like filtering, regex search, number of found items, etc)
    • This component can then be used both for search input box and replace the input box
  • When searching is active

    • The text should be highlighted in the editor as the user types search input
    • Count of found items should be rendered alongside search (with up/down arrows for navigation between search results)
    • When the search input box is focused
      • up/down arrow key should be used to navigate search results
    • When the user presses the ESC key, the search box should close as well as all highlighted items in the editor
      • Another ESC when search input is closed should work as previously (in VIM it should escape insert mode)
  • When search/replace is active

    • When the search is active (is focused)
      • Navigate should be active on keypresses (up/down)
    • When replace box is active (is focused)
      • enter key should replace the currently selected/highlighted item
    • There should be a replace button option as well as replace all option

Extra

  • This new local editor search implementation should avoid using escape as removing highlights from search results as ESC is used in VIM keymap to exit insert mode
Originally created by @Komediruzecki on GitHub (Jan 9, 2021). Original GitHub issue: https://github.com/BoostIO/BoostNote-App/issues/762 Originally assigned to: @Komediruzecki on GitHub. When exporting a note as an HTML file or a markdown file, assets used in the note should be exported too. ## Current behavior - Local editor search is using codemirror embedded search functionality. - Local editor search has bad shortcuts bound to it - Local editor search has hard to use search/replace process - Local editor search is inconsistent with global content search ## Expected behavior - Local editor search should use the same search functionality as global search (just scoped to current note and/or title) - Local editor search should have proper shortcuts bound to it - `ctrl+f` search/find text - `ctrl+r` search and replace - Local editor search should have double search bars (one for search and one for replacing at top of the editor) - Local editor search should use newly implemented global search algorithms (searching, highlighting, and marking text in codemirror) ## Implementation Details - There should be a component that consists of search input - This component should feature various options at the end of search input (like filtering, regex search, number of found items, etc) - This component can then be used both for search input box and replace the input box - When searching is active - The text should be highlighted in the editor as the user types search input - Count of found items should be rendered alongside search (with up/down arrows for navigation between search results) - When the search input box is focused - `up/down arrow` key should be used to navigate search results - When the user presses the ESC key, the search box should close as well as all highlighted items in the editor - Another ESC when search input is closed should work as previously (in VIM it should escape insert mode) - When search/replace is active - When the search is active (is focused) - Navigate should be active on keypresses (`up/down`) - When replace box is active (is focused) - `enter` key should replace the currently selected/highlighted item - There should be a replace button option as well as replace all option ## Extra - This new local editor search implementation should avoid using escape as removing highlights from search results as ESC is used in VIM keymap to exit insert mode
kerem 2026-03-03 00:20:49 +03:00
Author
Owner

@Komediruzecki commented on GitHub (May 18, 2021):

Merged and waiting for release.

<!-- gh-comment-id:843213393 --> @Komediruzecki commented on GitHub (May 18, 2021): Merged and waiting for release.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/BoostNote-App#394
No description provided.