mirror of
https://github.com/BoostIO/BoostNote-App.git
synced 2026-04-26 21:05:55 +03:00
[GH-ISSUE #755] Displaying preview resets cursor position to last search-found-position #392
Labels
No labels
android 🤖
assigned to core 🦹
bug 🐛
documentation 📚
documentation 📚
duplicate 🚫
external issue 🔼
external issue 🔼
feature request 🌟
funded on issuehunt 💵
help wanted 🆘
improvement request 🔨
improvement request 🔨
ios 🍎
mobile 📱
needs investigation 🔬
needs more info ℹ️
needs specs 📐
plugin idea 🔌
plugin idea 🔌
poll 🗳️
pull-request
question ❓
rewarded on issuehunt 🎁
security issue 🔑
won’t fix ❌
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/BoostNote-App#392
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @myicq on GitHub (Jan 4, 2021).
Original GitHub issue: https://github.com/BoostIO/BoostNote-App/issues/755
Current behavior
The cursor position is reset to top of markdown if preview (rendered text) is switched on and off.
Expected behavior
It is expected that editing can continue from same place regardless of preview state.
Not much of a problem for 10 line documents, but for really long texts, it's annoying to search the same spot again.
Steps to reproduce
Create a document and add around 10+ lines.
Position cursor at last line.
Activate preview using CTRL-E, then remove preview again. Cursor is now at top of document.
Same thing happens when split screen is activated: immediately as split screen shows, cursor jumps to start.
It is same for keypresses and menu icon usage.
BoostNote Legacy has the same "feature", so this may be more of a "feature" than an actual bug. Can it be avoided ?
Environment
Desktop/Web
Win 10 64 bit, BoostNote 0.12.3
@myicq commented on GitHub (Jan 19, 2021):
Update, boostnote.next 0.12.4: The cursor position seems to strangely be NOT at the top of the document, but at the location where last global search resullt was selected.
Example:
thisistheENDCTRL-P@Komediruzecki commented on GitHub (Jan 21, 2021):
Yes, it's kind of a mess now with all of this.
I'll try to see why this happens and prevent this.
Editor cursor should be kept stable even after preview is activated.
Editor cursor should change when you go to found item in search preview
Editor cursor should update when user moves it inside editor.
Does this sound good to you, do you have any other suggestions?
@myicq commented on GitHub (Mar 13, 2021):
@Rokt33r I think this sounds reasonable, with cursor being at same position on preview on/off, cursor located at found position, and cursor of course moving when user moves it.
@Komediruzecki commented on GitHub (May 28, 2021):
Hi myicq,
Just an update, local search feature was merged and released so now you can use local editor search and navigate to find/move cursor easier.
It still has the same problems with cursor being reset over opening/closing preview, but I will fix this for next release (hopefully next week) alongside whole local space refactor (new topbar UI, new sidebar with drag and drop, new theming, timeline feature from cloud space etc.)
Take you for your patience.