mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #1414] Fix Docker image builds CI messing up :latest, :stable, and :dev tags #2362
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#2362
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @stanthewizzard on GitHub (Apr 24, 2024).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/1414
Starting log:
Describe the bug
docker not starting
Steps to reproduce
docker compose
ArchiveBox version
docker latest image (24/04/2024)
Thanks for help
@Snyaify commented on GitHub (Apr 24, 2024):
same error after recent update :(
@stanthewizzard commented on GitHub (Apr 24, 2024):
my archive default has the issue also
ConsequentlyI made a clean one with the errro too
@ddoroshev commented on GitHub (Apr 24, 2024):
Looks like it caused by this recent commit (
authnever imported).Try
image: archivebox/archivebox:stable(#1391, comment)@stanthewizzard commented on GitHub (Apr 24, 2024):
thanks
what's the diff between stable and latest please ?
@rcarmo commented on GitHub (Apr 24, 2024):
Came here to report this as well. I would suggest running the migrations in CI to avoid pushing broken images to
:latest, since for many projects that is effectively "stable".@sclu1034 commented on GitHub (Apr 24, 2024):
I'd like to expand this question to all the alias tags. Because the deeper I dig, the more confusing it gets:
Like rcarmo said, the vast majority of projects I use consider
:latestto mean "stable", and point it to the newest release version. So far, ArchiveBox seemed to be doing the same, as the occasional mention of a:devtag in issues suggested that:latestwas not a development build.But now I've learned that there is also
:stable, and that it's different from:latest. So apparently:latestis not a development build, but also not a release build. But checking the list of tags,:latestalso isn't used by its literal name, as there is currently a nightly that's newer than:latest.:stableitself does seem relatively straightforward and true to its name, as it's aliased to the newest versioned tag.And then there's also
:main, apparently, which by its name suggests to be "the one to be used primarily". But it doesn't actually point to:stable, but to:latest, even though the linked issue above uses:mainand:stablein the same context (but does not use:latest, suggesting that:mainmight only sometimes be aliased to that).And finally,
:devsuggests by its name that it's an in-development build. But the current one is a month old, while both:stableand:latestare newer.Moreover, I'd generally expect installation instructions to suggest the stable, production-ready version. But the Wiki uses
:latestfor the manual Docker section, and the recommendeddocker-compose.ymleven uses:dev.Ideally, the tags would be migrated to something that aligns with common practices (either '
:latest== latest stable' or ':latest== any newest image'), but at the very least, there should be a page documenting all these aliases. And the installation instructions should probably be consistent in what image they use.@Cinj216 commented on GitHub (Apr 24, 2024):
THIS
@pirate commented on GitHub (Apr 24, 2024):
There is CI to handle all the tags as you'd expect but I broke it a couple ways with a recent big push, sorry all!
There are three issues that caused this:
maininstead ofdevyesterday by accident. It triggered a broken build getting tagged with:stable,:main, and:latestlast night while I was asleep. (becausemainwas the default branch and I didn't notice the PR wasn't based offdev, I've since fixed this):devwere succeeding but failing to tag them properly with the:devtag, so that tag ended up stale. (working on the fix now):stablerecently because some users asked for it, it's not yet handled by CI at all I just manually tagged it to be equal to the latest stable version, hence it didn't break when the others broke (will be CI-handled in the future)I'm working on fixing it right now. The final state should be:
:devshould be 1:1 with thedevbranch, aka unstable and likely to break once or twice a month during busy months:latestshould be 1:1 with the:stableand thestablebranch, wont be updated except for official mainline tagged version releases like0.7,0.7.1, etc.@pirate commented on GitHub (Apr 24, 2024):
Ok I just fixed all the tags manually, and I'm pushing the CI fixes next.
:latest==:stable==:0.7==:0.7.2==:sha-315c9f3==:mainThese ^ are all built from the
github.com/ArchiveBox/ArchiveBox@315c9f3commit (the0.7.2release commit from a few months ago), but as a side-effect of re-publishing them today, it bumped the unpinned dependency versions so it'll have the latestyt-dlp,chrome,wget,curl, etc. versions from 2024-04.:dev==:sha-b4c3aa5(for now, will updated once latestauth/import errors ondevbranch are fixed)The docs and scripts now exclusively recommend
archivebox/archivebox(aka:latestaka:stable):I've entirely removed references to
mainin the docs, the stable branch will now be known asstableand the tag will be:stable(equivalent to:latest). (it was only evermainbecause Github recommended everyone switch away from the oldmasterconvention)stableis just a better user-facing release channel name thanmain, so I'll centralize on that going forward and use it for both the Docker tag and Github branch name.@pirate commented on GitHub (Apr 24, 2024):
Out of curiosity, what setup are ya'll running that pulls new docker tags so quickly?
Are you using watchtower or some other auto-updater? And is the interval set to instant or daily?
Knowing how updates roll out and which users get them first helps me plan releases and tag updates in the future. (ArchiveBox collects no analytics, so even seemingly small info like this is very useful to me)
@rcarmo commented on GitHub (Apr 24, 2024):
Watchtower, yes. Daily updates for some containers, weekly for others.
@stanthewizzard commented on GitHub (Apr 25, 2024):
Watchtower running twice a day
@sclu1034 commented on GitHub (Apr 25, 2024):
Daily watchtower runs for me also.
@pirate commented on GitHub (Apr 25, 2024):
Ok thanks for your patience ya'll! Closing this for now.
btw the big PR that broke all these tags ^ is bringing some exciting new features soon, including the new REST API:
I'll roll a real release when it's stable, so you should all get it automatically when it's out!