mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[PR #1364] [MERGED] Use COOKIES_FILE to fetch page titles #1391
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#1391
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/1364
Author: @benmuth
Created: 2/27/2024
Status: ✅ Merged
Merged: 3/14/2024
Merged by: @pirate
Base:
dev← Head:title-cookies-file📝 Commits (5)
68326a6Add cookies file to http request indownload_urlfe11e1ccheck if COOKIE_FILE is filea577d1eMerge branch 'dev' into title-cookies-file4686da9Fix cookies being set incorrectly5082d61Merge branch 'title-cookies-file' of https://github.com/benmuth/ArchiveBox into title-cookies-file📊 Changes
1 file changed (+16 additions, -2 deletions)
View changed files
📝
archivebox/util.py(+16 -2)📄 Description
Summary
This PR lets the title extractor use the
COOKIES_FILE, if available. This helps avoid extracting the titles of captcha or login pages.Related issues
#761
Changes these areas
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
:latest,:stable, and:devtags #2362:latest,:stable, and:devtags #3872