starred/App-Store-Connect-CLI
1
0
Fork 0
mirror of https://github.com/rudrankriyam/App-Store-Connect-CLI.git synced 2026-04-25 23:55:51 +03:00
Code Issues 2 Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #321] Parity: Product Pages search keywords and media sets #92

New issue
Closed
opened 2026-02-26 21:33:19 +03:00 by kerem · 3 comments
kerem commented 2026-02-26 21:33:19 +03:00
Owner
Copy link

Originally created by @rudrankriyam on GitHub (Jan 30, 2026).
Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/321

Overview

Add missing Product Pages endpoints around localization search keywords and media sets (preview/screenshot sets) to align with OpenAPI.

Scope (OpenAPI resources)

  • appCustomProductPageLocalizations search keywords relationships
  • appCustomProductPageLocalizations preview sets + screenshot sets

Proposed CLI

Top-level group:

  • asc product-pages ...

New/expanded subcommands:

  • product-pages custom-pages localizations search-keywords list|add|delete --localization-id ID
  • product-pages custom-pages localizations preview-sets list --localization-id ID
  • product-pages custom-pages localizations screenshot-sets list --localization-id ID

Examples:

  • asc product-pages custom-pages localizations search-keywords list --localization-id LOC_ID
  • asc product-pages custom-pages localizations search-keywords add --localization-id LOC_ID --keywords "kw1,kw2"
  • asc product-pages custom-pages localizations preview-sets list --localization-id LOC_ID

Flag patterns

Common:

  • --localization-id, --output, --pretty, --confirm

Resource-specific:

  • --keywords (comma-separated)

Output

  • JSON minified by default
  • --pretty for JSON
  • --output table/markdown for list commands

Detailed TODO

  • Add client methods for localization search keywords endpoints
  • Add client methods for preview/screenshot set endpoints
  • Implement CLI search-keywords commands
  • Implement CLI preview/screenshot set list commands
  • Add cmdtests + HTTP client tests (mocked)

Acceptance criteria

  • Search keywords list/add/delete work for localizations
  • Preview/screenshot sets list works via localization ID
  • JSON-first output preserved

Tests

  • Flag validation tests
  • HTTP client tests for new endpoints
  • Output tests for list commands

Implementation notes

  • Add client methods in internal/asc/client_product_pages.go
  • Add CLI commands in internal/cli/productpages
  • Follow patterns from existing product pages localizations commands
Originally created by @rudrankriyam on GitHub (Jan 30, 2026). Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/321 # Overview Add missing Product Pages endpoints around localization search keywords and media sets (preview/screenshot sets) to align with OpenAPI. # Scope (OpenAPI resources) - `appCustomProductPageLocalizations` search keywords relationships - `appCustomProductPageLocalizations` preview sets + screenshot sets # Proposed CLI Top-level group: - `asc product-pages ...` New/expanded subcommands: - `product-pages custom-pages localizations search-keywords list|add|delete --localization-id ID` - `product-pages custom-pages localizations preview-sets list --localization-id ID` - `product-pages custom-pages localizations screenshot-sets list --localization-id ID` Examples: - `asc product-pages custom-pages localizations search-keywords list --localization-id LOC_ID` - `asc product-pages custom-pages localizations search-keywords add --localization-id LOC_ID --keywords "kw1,kw2"` - `asc product-pages custom-pages localizations preview-sets list --localization-id LOC_ID` # Flag patterns Common: - `--localization-id`, `--output`, `--pretty`, `--confirm` Resource-specific: - `--keywords` (comma-separated) # Output - JSON minified by default - `--pretty` for JSON - `--output table/markdown` for list commands # Detailed TODO - [ ] Add client methods for localization search keywords endpoints - [ ] Add client methods for preview/screenshot set endpoints - [ ] Implement CLI `search-keywords` commands - [ ] Implement CLI preview/screenshot set list commands - [ ] Add cmdtests + HTTP client tests (mocked) # Acceptance criteria - [ ] Search keywords list/add/delete work for localizations - [ ] Preview/screenshot sets list works via localization ID - [ ] JSON-first output preserved # Tests - Flag validation tests - HTTP client tests for new endpoints - Output tests for list commands # Implementation notes - Add client methods in `internal/asc/client_product_pages.go` - Add CLI commands in `internal/cli/productpages` - Follow patterns from existing product pages localizations commands
kerem closed this issue 2026-02-26 21:33:19 +03:00
kerem commented 2026-02-26 21:33:20 +03:00
Author
Owner
Copy link

@rudrankriyam commented on GitHub (Jan 30, 2026):

@cursor Please implement per issue description. No live credentials; use mocked tests. Run make build/lint/test and open a PR when green. Keep JSON-first output and explicit flags; no interactive prompts.

<!-- gh-comment-id:3822603159 --> @rudrankriyam commented on GitHub (Jan 30, 2026): @cursor Please implement per issue description. No live credentials; use mocked tests. Run make build/lint/test and open a PR when green. Keep JSON-first output and explicit flags; no interactive prompts.
kerem commented 2026-02-26 21:33:20 +03:00
Author
Owner
Copy link

@cursor[bot] commented on GitHub (Jan 30, 2026):

Summary:

  • I added ASC client support for custom product page localization search keywords plus preview/screenshot set fetches, along with appKeywords output formatting to keep JSON-first output consistent.
  • I implemented the new CLI subcommands under asc product-pages custom-pages localizations for search-keywords list|add|delete and preview-sets/screenshot-sets list, with explicit flags and no prompts.
  • I added mocked client tests, CLI flag-validation tests, and table/markdown output tests covering keywords and media set listings.

Tests (all passed):

  • make build
  • make lint
  • make test
  • go test ./internal/asc -run AppCustomProductPageLocalizationSearchKeywords
  • go test ./internal/cli/cmdtest -run SearchKeywords
    Walkthrough video: product_pages_search_keywords_tests/recording_demo.mp4 (shows the two targeted go test runs passing).

PR note: I pushed commits to cursor/product-pages-keywords-media-sets-0c04, but PR creation is handled by this environment, so I didn’t open one directly. If you want the direct PR URL, the push output suggested: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/new/cursor/product-pages-keywords-media-sets-0c04

View PR
Open in Cursor Open in Web

<!-- gh-comment-id:3822603525 --> @cursor[bot] commented on GitHub (Jan 30, 2026): Summary: - I added ASC client support for custom product page localization search keywords plus preview/screenshot set fetches, along with appKeywords output formatting to keep JSON-first output consistent. - I implemented the new CLI subcommands under `asc product-pages custom-pages localizations` for `search-keywords list|add|delete` and `preview-sets/screenshot-sets list`, with explicit flags and no prompts. - I added mocked client tests, CLI flag-validation tests, and table/markdown output tests covering keywords and media set listings. Tests (all passed): - `make build` - `make lint` - `make test` - `go test ./internal/asc -run AppCustomProductPageLocalizationSearchKeywords` - `go test ./internal/cli/cmdtest -run SearchKeywords` Walkthrough video: `product_pages_search_keywords_tests/recording_demo.mp4` (shows the two targeted go test runs passing). PR note: I pushed commits to `cursor/product-pages-keywords-media-sets-0c04`, but PR creation is handled by this environment, so I didn’t open one directly. If you want the direct PR URL, the push output suggested: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/new/cursor/product-pages-keywords-media-sets-0c04 <a href="https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/337"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/view-pr-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/view-pr-light.png"><img alt="View PR" width="86" height="28" src="https://cursor.com/assets/images/view-pr-light.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-84b83895-06e3-4857-a8e2-922777ef6345"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-84b83895-06e3-4857-a8e2-922777ef6345"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>
kerem commented 2026-02-26 21:33:20 +03:00
Author
Owner
Copy link

@rudrankriyam commented on GitHub (Jan 30, 2026):

Fixed by #337 and pagination/test updates in #341. Included in release 0.20.2.

<!-- gh-comment-id:3825187991 --> @rudrankriyam commented on GitHub (Jan 30, 2026): Fixed by #337 and pagination/test updates in #341. Included in release 0.20.2.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.1
1.1.0
1.0.1
1.0.0
0.49.1
0.49.0
0.48.1
0.48.0
0.47.1
0.47.0
0.46.2
0.46.1
0.46.0
0.45.4
0.45.3
0.45.2
0.45.1
0.45.0
0.44.2
0.44.1
0.44.0
0.43.0
0.42.0
0.41.4
0.41.3
0.41.2
0.41.1
0.41.0
0.40.1
0.40.0
0.39.1
0.39.0
0.38.3
0.38.2
0.38.1
0.38.0
0.37.3
0.37.2
0.37.1
0.37.0
0.36.3
0.36.2
0.36.1
0.36.0
0.35.3
0.35.2
0.35.1
0.35.0
0.34.1
0.34.0
0.33.2
0.33.1
0.33.0
0.32.0
0.31.3
0.31.2
0.31.1
0.31.0
0.30.0
0.29.3
0.29.2
0.29.1
0.29.0
0.28.14
0.28.13
0.28.12
0.28.11
0.28.10
0.28.9
0.28.8
0.28.7
0.28.6
0.28.5
0.28.4
0.28.3
0.28.2
0.28.1
0.28.0
0.27.0
0.26.4
0.26.3
0.26.2
0.26.1
0.26.0
0.25.4
0.25.3
0.25.1
0.25.0
0.24.3
0.24.2
0.24.1
0.24.0
0.23.5
0.23.4
0.23.3
0.23.2
0.23.1
0.23.0
0.22.1
0.22.0
0.21.0
0.20.2
0.20.1
0.20.0
0.19.3
0.19.2
0.19.1
0.19.0
0.18.2
0.18.1
0.18.0
0.17.0
0.16.0
0.15.0
0.14.0
0.13.0
0.12.4
0.12.3
0.12.2
0.12.1
0.12.0
0.11.0
0.10.2
0.10.1
0.10.0
0.9.0
0.8.1
0.8.0
0.7.0
0.6.0
0.5.0
0.3.1
0.3.0
0.2.0
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
Labels
Clear labels   
bug

   
bug

   
documentation

   
enhancement

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
bug
documentation
enhancement
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/App-Store-Connect-CLI#92
No description provided.