[PR #179] [MERGED] Credential name whitespace #341

Closed
opened 2026-02-26 21:34:39 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/179
Author: @cursor[bot]
Created: 1/26/2026
Status: Merged
Merged: 1/26/2026
Merged by: @rudrankriyam

Base: feat/auth-profilesHead: cursor/credential-name-whitespace-c4fa


📝 Commits (1)

  • f7e8cb4 Fix auth name trimming checks

📊 Changes

1 file changed (+13 additions, -8 deletions)

View changed files

📝 cmd/auth.go (+13 -8)

📄 Description

Fixes inconsistent whitespace handling in auth switch and auth logout commands to ensure correct profile matching and prevent unintended credential deletion.

The auth switch command now trims stored credential names before comparison, aligning with user input trimming. The auth logout command now consistently trims the provided name and explicitly errors on whitespace-only names, preventing a fallback to RemoveAllCredentials().



🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/179 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/26/2026 **Status:** ✅ Merged **Merged:** 1/26/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/auth-profiles` ← **Head:** `cursor/credential-name-whitespace-c4fa` --- ### 📝 Commits (1) - [`f7e8cb4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/f7e8cb43614ec751a3b8293d2d5e5835afd74c99) Fix auth name trimming checks ### 📊 Changes **1 file changed** (+13 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `cmd/auth.go` (+13 -8) </details> ### 📄 Description Fixes inconsistent whitespace handling in `auth switch` and `auth logout` commands to ensure correct profile matching and prevent unintended credential deletion. The `auth switch` command now trims stored credential names before comparison, aligning with user input trimming. The `auth logout` command now consistently trims the provided name and explicitly errors on whitespace-only names, preventing a fallback to `RemoveAllCredentials()`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 21:34:39 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/App-Store-Connect-CLI#341
No description provided.