starred/App-Store-Connect-CLI
1
0
Fork 0
mirror of https://github.com/rudrankriyam/App-Store-Connect-CLI.git synced 2026-04-25 15:45:48 +03:00
Code Issues 2 Projects Releases 10 Packages Wiki Activity

[PR #755] [MERGED] feat: wire --family-sharable flag for IAP and subscription create/update #767

New issue
Closed
opened 2026-02-26 22:32:28 +03:00 by kerem · 0 comments
kerem commented 2026-02-26 22:32:28 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/755
Author: @arnemoor
Created: 2/24/2026
Status: ✅ Merged
Merged: 2/24/2026
Merged by: @rudrankriyam

Base: main ← Head: feat/family-sharable-flag

📝 Commits (2)

  • 93aaa9a feat: wire --family-sharable flag for IAP and subscription create/update
  • 095bc68 ci: avoid bench comment failures on fork PRs

📊 Changes

5 files changed (+303 additions, -9 deletions)

View changed files

📝 .github/workflows/bench-compare.yml (+10 -1)
➕ internal/cli/cmdtest/iap_family_sharable_test.go (+131 -0)
➕ internal/cli/cmdtest/subscriptions_family_sharable_test.go (+131 -0)
📝 internal/cli/iap/iap.go (+16 -5)
📝 internal/cli/subscriptions/subscriptions.go (+15 -3)

📄 Description

Summary

  • Expose familySharable API field as --family-sharable CLI flag on iap create, iap update, subscriptions create, and subscriptions update
  • Update commands accept --family-sharable as a sole update flag (no "at least one update flag" error)
  • Apple states family sharing cannot be disabled once enabled, so the flag is one-way (present = enable, absent = no change)

Test plan

  • TestIAPCreateFamilySharable — verifies request body contains "familySharable":true
  • TestIAPUpdateFamilySharableAsSoleFlag — verifies --family-sharable alone is sufficient, no other attrs set
  • TestSubscriptionsCreateFamilySharable — same for subscriptions create
  • TestSubscriptionsUpdateFamilySharableAsSoleFlag — same for subscriptions update
  • ASC_BYPASS_KEYCHAIN=1 make test — full suite green
  • make format — clean
  • Help output verified: asc iap create --help | grep family etc.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/755 **Author:** [@arnemoor](https://github.com/arnemoor) **Created:** 2/24/2026 **Status:** ✅ Merged **Merged:** 2/24/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feat/family-sharable-flag` --- ### 📝 Commits (2) - [`93aaa9a`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/93aaa9af1c23fbe9a74d4f13773e3be12fc5f478) feat: wire --family-sharable flag for IAP and subscription create/update - [`095bc68`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/095bc6880081da9aa1e00636ccdaa51f81fd199c) ci: avoid bench comment failures on fork PRs ### 📊 Changes **5 files changed** (+303 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/bench-compare.yml` (+10 -1) ➕ `internal/cli/cmdtest/iap_family_sharable_test.go` (+131 -0) ➕ `internal/cli/cmdtest/subscriptions_family_sharable_test.go` (+131 -0) 📝 `internal/cli/iap/iap.go` (+16 -5) 📝 `internal/cli/subscriptions/subscriptions.go` (+15 -3) </details> ### 📄 Description ## Summary - Expose `familySharable` API field as `--family-sharable` CLI flag on `iap create`, `iap update`, `subscriptions create`, and `subscriptions update` - Update commands accept `--family-sharable` as a sole update flag (no "at least one update flag" error) - Apple states family sharing cannot be disabled once enabled, so the flag is one-way (present = enable, absent = no change) ## Test plan - [x] `TestIAPCreateFamilySharable` — verifies request body contains `"familySharable":true` - [x] `TestIAPUpdateFamilySharableAsSoleFlag` — verifies `--family-sharable` alone is sufficient, no other attrs set - [x] `TestSubscriptionsCreateFamilySharable` — same for subscriptions create - [x] `TestSubscriptionsUpdateFamilySharableAsSoleFlag` — same for subscriptions update - [x] `ASC_BYPASS_KEYCHAIN=1 make test` — full suite green - [x] `make format` — clean - [x] Help output verified: `asc iap create --help | grep family` etc. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 22:32:28 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.1
1.1.0
1.0.1
1.0.0
0.49.1
0.49.0
0.48.1
0.48.0
0.47.1
0.47.0
0.46.2
0.46.1
0.46.0
0.45.4
0.45.3
0.45.2
0.45.1
0.45.0
0.44.2
0.44.1
0.44.0
0.43.0
0.42.0
0.41.4
0.41.3
0.41.2
0.41.1
0.41.0
0.40.1
0.40.0
0.39.1
0.39.0
0.38.3
0.38.2
0.38.1
0.38.0
0.37.3
0.37.2
0.37.1
0.37.0
0.36.3
0.36.2
0.36.1
0.36.0
0.35.3
0.35.2
0.35.1
0.35.0
0.34.1
0.34.0
0.33.2
0.33.1
0.33.0
0.32.0
0.31.3
0.31.2
0.31.1
0.31.0
0.30.0
0.29.3
0.29.2
0.29.1
0.29.0
0.28.14
0.28.13
0.28.12
0.28.11
0.28.10
0.28.9
0.28.8
0.28.7
0.28.6
0.28.5
0.28.4
0.28.3
0.28.2
0.28.1
0.28.0
0.27.0
0.26.4
0.26.3
0.26.2
0.26.1
0.26.0
0.25.4
0.25.3
0.25.1
0.25.0
0.24.3
0.24.2
0.24.1
0.24.0
0.23.5
0.23.4
0.23.3
0.23.2
0.23.1
0.23.0
0.22.1
0.22.0
0.21.0
0.20.2
0.20.1
0.20.0
0.19.3
0.19.2
0.19.1
0.19.0
0.18.2
0.18.1
0.18.0
0.17.0
0.16.0
0.15.0
0.14.0
0.13.0
0.12.4
0.12.3
0.12.2
0.12.1
0.12.0
0.11.0
0.10.2
0.10.1
0.10.0
0.9.0
0.8.1
0.8.0
0.7.0
0.6.0
0.5.0
0.3.1
0.3.0
0.2.0
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
Labels
Clear labels   
bug

   
bug

   
documentation

   
enhancement

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
bug
documentation
enhancement
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/App-Store-Connect-CLI#767
No description provided.