[PR #744] [MERGED] fix(screenshots): focus default sizes on iOS submission slots #755

New issue

Closed

opened 2026-02-26 22:32:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/744
Author: @rudrankriyam
Created: 2/23/2026
Status: ✅ Merged
Merged: 2/23/2026
Merged by: @rudrankriyam

Base: main ← Head: fix/screenshot-help-single-ios-ipad

📝 Commits (1)

2acd6cb fix(screenshots): focus default sizes on iOS submission slots

📊 Changes

8 files changed (+263 additions, -22 deletions)

View changed files

📝 internal/asc/screenshot_sizes.go (+4 -1)
📝 internal/asc/screenshot_sizes_test.go (+44 -0)
📝 internal/cli/assets/assets_screenshots.go (+45 -7)
📝 internal/cli/assets/assets_screenshots_test.go (+96 -0)
📝 internal/cli/cmdtest/assets_screenshots_sizes_test.go (+42 -10)
📝 internal/cli/screenshots/screenshots.go (+9 -3)
📝 internal/validation/screenshot_test.go (+19 -0)
📝 internal/validation/screenshots.go (+4 -1)

📄 Description

Summary

Default asc screenshots sizes to the focused iOS submission slots (APP_IPHONE_65 and APP_IPAD_PRO_3GEN_129) and add --all for the full matrix.
Update screenshot command help/examples to guide users toward one iPhone and one iPad set by default, with explicit opt-in for all sizes.
Accept 1284x2778 as a valid APP_IPHONE_65 size and align both validation paths and tests with the consolidated App Store Connect slot behavior.

Test plan

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test
go test ./internal/cli/assets ./internal/cli/cmdtest ./internal/cli/screenshots
go run . screenshots sizes --output table
go run . screenshots sizes --all --output table

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/744 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/23/2026 **Status:** ✅ Merged **Merged:** 2/23/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `fix/screenshot-help-single-ios-ipad` --- ### 📝 Commits (1) - [`2acd6cb`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/2acd6cb2835ca59c0c189fb069d2b2187469c81f) fix(screenshots): focus default sizes on iOS submission slots ### 📊 Changes **8 files changed** (+263 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/screenshot_sizes.go` (+4 -1) 📝 `internal/asc/screenshot_sizes_test.go` (+44 -0) 📝 `internal/cli/assets/assets_screenshots.go` (+45 -7) 📝 `internal/cli/assets/assets_screenshots_test.go` (+96 -0) 📝 `internal/cli/cmdtest/assets_screenshots_sizes_test.go` (+42 -10) 📝 `internal/cli/screenshots/screenshots.go` (+9 -3) 📝 `internal/validation/screenshot_test.go` (+19 -0) 📝 `internal/validation/screenshots.go` (+4 -1) </details> ### 📄 Description ## Summary - Default `asc screenshots sizes` to the focused iOS submission slots (`APP_IPHONE_65` and `APP_IPAD_PRO_3GEN_129`) and add `--all` for the full matrix. - Update screenshot command help/examples to guide users toward one iPhone and one iPad set by default, with explicit opt-in for all sizes. - Accept `1284x2778` as a valid `APP_IPHONE_65` size and align both validation paths and tests with the consolidated App Store Connect slot behavior. ## Test plan - [x] `make format` - [x] `make lint` - [x] `ASC_BYPASS_KEYCHAIN=1 make test` - [x] `go test ./internal/cli/assets ./internal/cli/cmdtest ./internal/cli/screenshots` - [x] `go run . screenshots sizes --output table` - [x] `go run . screenshots sizes --all --output table` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>