[PR #754] [CLOSED] feat: wire --family-sharable flag for IAP and subscription create/update #766

New issue

Closed

opened 2026-02-26 22:32:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/754
Author: @arnemoor
Created: 2/24/2026
Status: ❌ Closed

Base: main ← Head: feat/family-sharable-flag

📝 Commits (1)

93aaa9a feat: wire --family-sharable flag for IAP and subscription create/update

📊 Changes

4 files changed (+293 additions, -8 deletions)

View changed files

➕ internal/cli/cmdtest/iap_family_sharable_test.go (+131 -0)
➕ internal/cli/cmdtest/subscriptions_family_sharable_test.go (+131 -0)
📝 internal/cli/iap/iap.go (+16 -5)
📝 internal/cli/subscriptions/subscriptions.go (+15 -3)

📄 Description

Summary

Expose familySharable API field as --family-sharable CLI flag on iap create, iap update, subscriptions create, and subscriptions update
Update commands accept --family-sharable as a sole update flag (no "at least one update flag" error)
Apple states family sharing cannot be disabled once enabled, so the flag is one-way (present = enable, absent = no change)

Test plan

TestIAPCreateFamilySharable — verifies request body contains "familySharable":true
TestIAPUpdateFamilySharableAsSoleFlag — verifies --family-sharable alone is sufficient, no other attrs set
TestSubscriptionsCreateFamilySharable — same for subscriptions create
TestSubscriptionsUpdateFamilySharableAsSoleFlag — same for subscriptions update
ASC_BYPASS_KEYCHAIN=1 make test — full suite green
make format — clean
Help output verified: asc iap create --help | grep family etc.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/754 **Author:** [@arnemoor](https://github.com/arnemoor) **Created:** 2/24/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/family-sharable-flag` --- ### 📝 Commits (1) - [`93aaa9a`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/93aaa9af1c23fbe9a74d4f13773e3be12fc5f478) feat: wire --family-sharable flag for IAP and subscription create/update ### 📊 Changes **4 files changed** (+293 additions, -8 deletions) <details> <summary>View changed files</summary> ➕ `internal/cli/cmdtest/iap_family_sharable_test.go` (+131 -0) ➕ `internal/cli/cmdtest/subscriptions_family_sharable_test.go` (+131 -0) 📝 `internal/cli/iap/iap.go` (+16 -5) 📝 `internal/cli/subscriptions/subscriptions.go` (+15 -3) </details> ### 📄 Description ## Summary - Expose `familySharable` API field as `--family-sharable` CLI flag on `iap create`, `iap update`, `subscriptions create`, and `subscriptions update` - Update commands accept `--family-sharable` as a sole update flag (no "at least one update flag" error) - Apple states family sharing cannot be disabled once enabled, so the flag is one-way (present = enable, absent = no change) ## Test plan - [x] `TestIAPCreateFamilySharable` — verifies request body contains `"familySharable":true` - [x] `TestIAPUpdateFamilySharableAsSoleFlag` — verifies `--family-sharable` alone is sufficient, no other attrs set - [x] `TestSubscriptionsCreateFamilySharable` — same for subscriptions create - [x] `TestSubscriptionsUpdateFamilySharableAsSoleFlag` — same for subscriptions update - [x] `ASC_BYPASS_KEYCHAIN=1 make test` — full suite green - [x] `make format` — clean - [x] Help output verified: `asc iap create --help | grep family` etc. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>