[PR #742] [MERGED] Add localizations update subcommand for direct field updates #754

New issue

Closed

opened 2026-02-26 22:32:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/742
Author: @omar16100
Created: 2/23/2026
Status: ✅ Merged
Merged: 2/23/2026
Merged by: @rudrankriyam

Base: main ← Head: feedback/localizations-update

📝 Commits (1)

cc7acda feat(localizations): add update subcommand for direct field updates

📊 Changes

3 files changed (+408 additions, -0 deletions)

View changed files

➕ internal/cli/cmdtest/localizations_update_test.go (+175 -0)
📝 internal/cli/localizations/localizations.go (+1 -0)
➕ internal/cli/localizations/update.go (+232 -0)

📄 Description

Summary

Adds asc localizations update for directly updating localization fields without preparing JSON or .strings files
Supports both --type app-info and --type version localization types
Resolves existing localization by --locale, then PATCHes only the specified fields

Usage

# Set subtitle for a locale
asc localizations update --app APP_ID --type app-info --locale en-US --subtitle "My Subtitle"

# Update version description
asc localizations update --version-id VER_ID --type version --locale en-US --description "New description"

Supported flags

App-info type: --name, --subtitle, --privacy-policy-url, --privacy-choices-url, --privacy-policy-text
Version type: --description, --keywords, --whats-new, --promotional-text, --support-url, --marketing-url

Files changed

internal/cli/localizations/update.go — LocalizationsUpdateCommand() (~232 lines)
internal/cli/localizations/localizations.go — registers new subcommand (+1 line)
internal/cli/cmdtest/localizations_update_test.go — 5 tests including HTTP mock integration

Test plan

TestLocalizationsUpdateRequiresLocale — validates --locale is required
TestLocalizationsUpdateRequiresAtLeastOneField — validates at least one field flag
TestLocalizationsUpdateAppInfoRequiresApp — validates --app for app-info type
TestLocalizationsUpdateVersionRequiresVersion — validates --version/--version-id for version type
TestLocalizationsUpdateAppInfoSubtitle — full HTTP mock integration test
ASC_BYPASS_KEYCHAIN=1 make test — all tests pass

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/742 **Author:** [@omar16100](https://github.com/omar16100) **Created:** 2/23/2026 **Status:** ✅ Merged **Merged:** 2/23/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feedback/localizations-update` --- ### 📝 Commits (1) - [`cc7acda`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/cc7acda4648387138b6f67753e9c103293c990ab) feat(localizations): add update subcommand for direct field updates ### 📊 Changes **3 files changed** (+408 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `internal/cli/cmdtest/localizations_update_test.go` (+175 -0) 📝 `internal/cli/localizations/localizations.go` (+1 -0) ➕ `internal/cli/localizations/update.go` (+232 -0) </details> ### 📄 Description ## Summary - Adds `asc localizations update` for directly updating localization fields without preparing JSON or .strings files - Supports both `--type app-info` and `--type version` localization types - Resolves existing localization by `--locale`, then PATCHes only the specified fields ## Usage ```bash # Set subtitle for a locale asc localizations update --app APP_ID --type app-info --locale en-US --subtitle "My Subtitle" # Update version description asc localizations update --version-id VER_ID --type version --locale en-US --description "New description" ``` ## Supported flags **App-info type:** `--name`, `--subtitle`, `--privacy-policy-url`, `--privacy-choices-url`, `--privacy-policy-text` **Version type:** `--description`, `--keywords`, `--whats-new`, `--promotional-text`, `--support-url`, `--marketing-url` ## Files changed - `internal/cli/localizations/update.go` — `LocalizationsUpdateCommand()` (~232 lines) - `internal/cli/localizations/localizations.go` — registers new subcommand (+1 line) - `internal/cli/cmdtest/localizations_update_test.go` — 5 tests including HTTP mock integration ## Test plan - [x] `TestLocalizationsUpdateRequiresLocale` — validates --locale is required - [x] `TestLocalizationsUpdateRequiresAtLeastOneField` — validates at least one field flag - [x] `TestLocalizationsUpdateAppInfoRequiresApp` — validates --app for app-info type - [x] `TestLocalizationsUpdateVersionRequiresVersion` — validates --version/--version-id for version type - [x] `TestLocalizationsUpdateAppInfoSubtitle` — full HTTP mock integration test - [x] `ASC_BYPASS_KEYCHAIN=1 make test` — all tests pass --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>