[PR #717] [MERGED] Custom page code quality #734

New issue

Closed

opened 2026-02-26 22:32:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/717
Author: @cursor[bot]
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/21/2026
Merged by: @rudrankriyam

Base: feat/cpp-media-upload-sync ← Head: cursor/custom-page-code-quality-3e1d

📝 Commits (1)

f1b3b24 refactor custom page media upload to reuse asset helpers

📊 Changes

3 files changed (+18 additions, -66 deletions)

View changed files

📝 internal/cli/assets/assets_previews.go (+5 -0)
📝 internal/cli/assets/assets_screenshots.go (+10 -0)
📝 internal/cli/productpages/custom_page_localization_media_upload.go (+3 -66)

📄 Description

Summary

Removed dead code related to custom page asset delivery state polling and error formatting, as these operations are already handled by the delegated assets package functions.
Refactored custom page media upload logic to reuse existing, now-exported, asset normalization and validation functions from the assets package, eliminating duplicated code.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/717 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/21/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/cpp-media-upload-sync` ← **Head:** `cursor/custom-page-code-quality-3e1d` --- ### 📝 Commits (1) - [`f1b3b24`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/f1b3b241099dad28c19d1157cbf66552be6adf52) refactor custom page media upload to reuse asset helpers ### 📊 Changes **3 files changed** (+18 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/assets/assets_previews.go` (+5 -0) 📝 `internal/cli/assets/assets_screenshots.go` (+10 -0) 📝 `internal/cli/productpages/custom_page_localization_media_upload.go` (+3 -66) </details> ### 📄 Description ## Summary - Removed dead code related to custom page asset delivery state polling and error formatting, as these operations are already handled by the delegated `assets` package functions. - Refactored custom page media upload logic to reuse existing, now-exported, asset normalization and validation functions from the `assets` package, eliminating duplicated code. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>