[PR #716] [MERGED] Slack message text duplication #733

New issue

Closed

opened 2026-02-26 22:32:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/716
Author: @cursor[bot]
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/21/2026
Merged by: @rudrankriyam

Base: feat/notify-slack-thread-release-payload ← Head: cursor/slack-message-text-duplication-c6a7

📝 Commits (1)

5828576 notify slack: avoid duplicate attachment message text

📊 Changes

2 files changed (+10 additions, -2 deletions)

View changed files

📝 internal/cli/notify/notify.go (+1 -2)
📝 internal/cli/notify/notify_test.go (+9 -0)

📄 Description

Summary

Fixes a bug where Slack notifications displayed the message text twice (in the top-level message and within the attachment body). The attachment's text field is now omitted when a top-level message is already provided, preventing visual duplication and aligning with Slack's best practices for attachments.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/716 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/21/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/notify-slack-thread-release-payload` ← **Head:** `cursor/slack-message-text-duplication-c6a7` --- ### 📝 Commits (1) - [`5828576`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/5828576ea5235af894d4a9f35f1317f4a6661cfe) notify slack: avoid duplicate attachment message text ### 📊 Changes **2 files changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/notify/notify.go` (+1 -2) 📝 `internal/cli/notify/notify_test.go` (+9 -0) </details> ### 📄 Description ## Summary - Fixes a bug where Slack notifications displayed the message text twice (in the top-level message and within the attachment body). The attachment's `text` field is now omitted when a top-level message is already provided, preventing visual duplication and aligning with Slack's best practices for attachments. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>