[PR #698] [MERGED] Unused localization writer #719

New issue

Closed

opened 2026-02-26 22:32:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/698
Author: @cursor[bot]
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @rudrankriyam

Base: feat/metadata-fastlane-parity-587 ← Head: cursor/unused-localization-writer-7302

📝 Commits (1)

77942a4 metadata: remove unused WriteVersionLocalizationFile helper

📊 Changes

1 file changed (+0 additions, -9 deletions)

View changed files

📝 internal/cli/metadata/foundation.go (+0 -9)

📄 Description

Summary

Made the unused exported function WriteVersionLocalizationFile unexported (writeVersionLocalizationFile) to reduce the public API surface and maintenance burden.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/698 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/metadata-fastlane-parity-587` ← **Head:** `cursor/unused-localization-writer-7302` --- ### 📝 Commits (1) - [`77942a4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/77942a45a4968d0e520d0610c1a2eac6f3f585c7) metadata: remove unused WriteVersionLocalizationFile helper ### 📊 Changes **1 file changed** (+0 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/metadata/foundation.go` (+0 -9) </details> ### 📄 Description ## Summary - Made the unused exported function `WriteVersionLocalizationFile` unexported (`writeVersionLocalizationFile`) to reduce the public API surface and maintenance burden. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>