[PR #669] [MERGED] Diff command code quality #698

New issue

Closed

opened 2026-02-26 22:32:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/669
Author: @cursor[bot]
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @rudrankriyam

Base: feat/metadata-diff-586 ← Head: cursor/diff-command-code-quality-8e47

📝 Commits (1)

b109a99 Remove duplicated localization mapping logic

📊 Changes

2 files changed (+16 additions, -28 deletions)

View changed files

📝 internal/cli/diffcmd/localizations.go (+6 -28)
📝 internal/cli/shared/localizations.go (+10 -0)

📄 Description

Summary

Refactored localization attribute handling to use shared, exported utilities, eliminating duplicated code in diffcmd and reducing maintenance risk.
Removed unreachable dead code related to source version validation in diffcmd.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/669 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/metadata-diff-586` ← **Head:** `cursor/diff-command-code-quality-8e47` --- ### 📝 Commits (1) - [`b109a99`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b109a99b5255cda5247b50ed90d4cc47747ab597) Remove duplicated localization mapping logic ### 📊 Changes **2 files changed** (+16 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/diffcmd/localizations.go` (+6 -28) 📝 `internal/cli/shared/localizations.go` (+10 -0) </details> ### 📄 Description ## Summary - Refactored localization attribute handling to use shared, exported utilities, eliminating duplicated code in `diffcmd` and reducing maintenance risk. - Removed unreachable dead code related to source version validation in `diffcmd`. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>