[PR #667] [MERGED] Webhooks body size dead code #696

New issue

Closed

opened 2026-02-26 22:32:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/667
Author: @cursor[bot]
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @rudrankriyam

Base: feat/webhooks-serve-590 ← Head: cursor/webhooks-body-size-dead-code-d37b

📝 Commits (1)

be53483 Remove unreachable webhook body size check

📊 Changes

1 file changed (+0 additions, -3 deletions)

View changed files

📝 internal/cli/webhooks/webhooks_serve.go (+0 -3)

📄 Description

Summary

Removed an unreachable body-size check (int64(len(raw)) > maxBodyBytes) in internal/cli/webhooks/webhooks_serve.go. This condition was dead code because io.LimitedReader ensures the read raw byte slice will never exceed maxBodyBytes, making the check always false.

Validation

make format
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/667 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/webhooks-serve-590` ← **Head:** `cursor/webhooks-body-size-dead-code-d37b` --- ### 📝 Commits (1) - [`be53483`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/be534839841634224e34cfc2665036372614c178) Remove unreachable webhook body size check ### 📊 Changes **1 file changed** (+0 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/webhooks/webhooks_serve.go` (+0 -3) </details> ### 📄 Description ## Summary - Removed an unreachable body-size check (`int64(len(raw)) > maxBodyBytes`) in `internal/cli/webhooks/webhooks_serve.go`. This condition was dead code because `io.LimitedReader` ensures the read `raw` byte slice will never exceed `maxBodyBytes`, making the check always false. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>