[PR #665] [MERGED] Webhook serving issues #695

New issue

Closed

opened 2026-02-26 22:32:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/665
Author: @cursor[bot]
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @rudrankriyam

Base: feat/webhooks-serve-590 ← Head: cursor/webhook-serving-issues-6363

📝 Commits (1)

0cd7a24 Fix webhook serve max-body overflow and drop redundant unmarshal

📊 Changes

2 files changed (+20 additions, -6 deletions)

View changed files

📝 internal/cli/webhooks/webhooks_serve.go (+6 -6)
📝 internal/cli/webhooks/webhooks_serve_test.go (+14 -0)

📄 Description

Summary

Prevented integer overflow in io.LimitReader when maxBodyBytes is math.MaxInt64 by adding a validation check.
Removed redundant json.Unmarshal call, as json.Compact already provides sufficient JSON syntax validation, reducing unnecessary memory allocation.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/665 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/webhooks-serve-590` ← **Head:** `cursor/webhook-serving-issues-6363` --- ### 📝 Commits (1) - [`0cd7a24`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/0cd7a24605113598e4fd2d8bac27d3708663622c) Fix webhook serve max-body overflow and drop redundant unmarshal ### 📊 Changes **2 files changed** (+20 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/webhooks/webhooks_serve.go` (+6 -6) 📝 `internal/cli/webhooks/webhooks_serve_test.go` (+14 -0) </details> ### 📄 Description ## Summary - Prevented integer overflow in `io.LimitReader` when `maxBodyBytes` is `math.MaxInt64` by adding a validation check. - Removed redundant `json.Unmarshal` call, as `json.Compact` already provides sufficient JSON syntax validation, reducing unnecessary memory allocation. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>