[PR #630] [MERGED] asc: add missing relationship endpoints (issue #619) #663

New issue

Closed

opened 2026-02-26 22:32:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/630
Author: @rudrankriyam
Created: 2/18/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/issue-619-asc-relationship-coverage-clean

📝 Commits (1)

38eb9da coverage: add missing subscriptions/IAP/pricing relationship endpoints

📊 Changes

9 files changed (+1980 additions, -0 deletions)

View changed files

📝 internal/asc/client_iap_subresources.go (+547 -0)
📝 internal/asc/client_pricing.go (+132 -0)
📝 internal/asc/client_subscription_resources.go (+140 -0)
📝 internal/asc/client_subscriptions.go (+493 -0)
➕ internal/asc/iap_relationships_http_test.go (+211 -0)
📝 internal/asc/offer_codes.go (+36 -0)
➕ internal/asc/pricing_relationships_http_test.go (+88 -0)
➕ internal/asc/subscriptions_relationships_http_test.go (+282 -0)
📝 internal/cli/cmdtest/release_notes_generate_test.go (+51 -0)

📄 Description

Summary

Add missing relationship GET endpoints for subscriptions, IAP, and pricing (linkages + to-one linkage responses) per OpenAPI.
Add missing subscription relationship DELETE endpoints (introductory offers + prices) using existing relationship payload helpers.
Add request-shaping HTTP tests for the new relationship endpoints.
Harden release-notes cmdtests against git hook env var leakage (GIT_DIR/GIT_WORK_TREE/etc).

Closes #619.

Test plan

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/630 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/18/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/issue-619-asc-relationship-coverage-clean` --- ### 📝 Commits (1) - [`38eb9da`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/38eb9dac4b5901a4b16d5f648d2e647cae534c2b) coverage: add missing subscriptions/IAP/pricing relationship endpoints ### 📊 Changes **9 files changed** (+1980 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_iap_subresources.go` (+547 -0) 📝 `internal/asc/client_pricing.go` (+132 -0) 📝 `internal/asc/client_subscription_resources.go` (+140 -0) 📝 `internal/asc/client_subscriptions.go` (+493 -0) ➕ `internal/asc/iap_relationships_http_test.go` (+211 -0) 📝 `internal/asc/offer_codes.go` (+36 -0) ➕ `internal/asc/pricing_relationships_http_test.go` (+88 -0) ➕ `internal/asc/subscriptions_relationships_http_test.go` (+282 -0) 📝 `internal/cli/cmdtest/release_notes_generate_test.go` (+51 -0) </details> ### 📄 Description ## Summary - Add missing relationship GET endpoints for subscriptions, IAP, and pricing (linkages + to-one linkage responses) per OpenAPI. - Add missing subscription relationship DELETE endpoints (introductory offers + prices) using existing relationship payload helpers. - Add request-shaping HTTP tests for the new relationship endpoints. - Harden release-notes cmdtests against git hook env var leakage (GIT_DIR/GIT_WORK_TREE/etc). Closes #619. ## Test plan - make format - make lint - ASC_BYPASS_KEYCHAIN=1 make test --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>