[PR #557] [MERGED] validate: expand readiness checks #619

New issue

Closed

opened 2026-02-26 22:31:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/557
Author: @rudrankriyam
Created: 2/15/2026
Status: ✅ Merged
Merged: 2/16/2026
Merged by: @rudrankriyam

Base: main ← Head: validate/screenshot-presence

📝 Commits (6)

54ba514 validate: expand readiness checks
e514c08 validate: harden availability and pagination
2de21e7 validate: detect missing build when data is null
7556a33 Fix validate handling of null categories and screenshot locale fallback
cd357e0 Merge pull request #558 from rudrankriyam/cursor/empty-build-data-validation-713b
bfb81f6 Merge pull request #559 from rudrankriyam/cursor/category-and-screenshot-validation-eea8

📊 Changes

29 files changed (+3157 additions, -17 deletions)

View changed files

📝 internal/asc/output_validate.go (+130 -0)
📝 internal/asc/types/resources.go (+29 -1)
➕ internal/cli/cmdtest/validate_iap_test.go (+188 -0)
➕ internal/cli/cmdtest/validate_subscriptions_test.go (+199 -0)
📝 internal/cli/cmdtest/validate_test.go (+538 -13)
➕ internal/cli/cmdtest/validate_testflight_test.go (+302 -0)
➕ internal/cli/validate/iap.go (+117 -0)
➕ internal/cli/validate/subscriptions.go (+145 -0)
➕ internal/cli/validate/testflight.go (+171 -0)
📝 internal/cli/validate/validate.go (+132 -3)
➕ internal/validation/builds.go (+49 -0)
➕ internal/validation/builds_test.go (+42 -0)
➕ internal/validation/categories.go (+20 -0)
➕ internal/validation/categories_test.go (+17 -0)
➕ internal/validation/iap.go (+124 -0)
➕ internal/validation/iap_test.go (+43 -0)
➕ internal/validation/pricing_availability.go (+55 -0)
➕ internal/validation/pricing_availability_test.go (+38 -0)
📝 internal/validation/report.go (+6 -0)
➕ internal/validation/review_details.go (+57 -0)

...and 9 more files

📄 Description

Summary

Expand asc validate (App Store version) with additional requiredness checks: review details, primary category, attached build processed, pricing/availability, and screenshot presence.
Add asc validate testflight for TestFlight build readiness (beta review details + What to Test).
Add asc validate iap and asc validate subscriptions to flag monetization items that may block review (warning-only by default; use --strict to gate).

Test Plan

make lint
ASC_BYPASS_KEYCHAIN=1 make test
Manual smoke (optional): run asc validate, asc validate testflight, asc validate iap, asc validate subscriptions against a real app.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/557 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/15/2026 **Status:** ✅ Merged **Merged:** 2/16/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `validate/screenshot-presence` --- ### 📝 Commits (6) - [`54ba514`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/54ba514867e821c6a22723862f90fe93e8c8fcf6) validate: expand readiness checks - [`e514c08`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/e514c087f793d9132b48242c67a06372179a75f0) validate: harden availability and pagination - [`2de21e7`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/2de21e7e4ea861e2c3a5655e23031c2a230d3de2) validate: detect missing build when data is null - [`7556a33`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/7556a33d0ca334ec788542ef249cb875bfe997c5) Fix validate handling of null categories and screenshot locale fallback - [`cd357e0`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/cd357e0cd884aeedef70dbe765bc00c9378656d3) Merge pull request #558 from rudrankriyam/cursor/empty-build-data-validation-713b - [`bfb81f6`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/bfb81f6bd2ff57a2d0acbcb8eeea6d4e08b0db91) Merge pull request #559 from rudrankriyam/cursor/category-and-screenshot-validation-eea8 ### 📊 Changes **29 files changed** (+3157 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/output_validate.go` (+130 -0) 📝 `internal/asc/types/resources.go` (+29 -1) ➕ `internal/cli/cmdtest/validate_iap_test.go` (+188 -0) ➕ `internal/cli/cmdtest/validate_subscriptions_test.go` (+199 -0) 📝 `internal/cli/cmdtest/validate_test.go` (+538 -13) ➕ `internal/cli/cmdtest/validate_testflight_test.go` (+302 -0) ➕ `internal/cli/validate/iap.go` (+117 -0) ➕ `internal/cli/validate/subscriptions.go` (+145 -0) ➕ `internal/cli/validate/testflight.go` (+171 -0) 📝 `internal/cli/validate/validate.go` (+132 -3) ➕ `internal/validation/builds.go` (+49 -0) ➕ `internal/validation/builds_test.go` (+42 -0) ➕ `internal/validation/categories.go` (+20 -0) ➕ `internal/validation/categories_test.go` (+17 -0) ➕ `internal/validation/iap.go` (+124 -0) ➕ `internal/validation/iap_test.go` (+43 -0) ➕ `internal/validation/pricing_availability.go` (+55 -0) ➕ `internal/validation/pricing_availability_test.go` (+38 -0) 📝 `internal/validation/report.go` (+6 -0) ➕ `internal/validation/review_details.go` (+57 -0) _...and 9 more files_ </details> ### 📄 Description ## Summary - Expand `asc validate` (App Store version) with additional requiredness checks: review details, primary category, attached build processed, pricing/availability, and screenshot presence. - Add `asc validate testflight` for TestFlight build readiness (beta review details + What to Test). - Add `asc validate iap` and `asc validate subscriptions` to flag monetization items that may block review (warning-only by default; use `--strict` to gate). ## Test Plan - `make lint` - `ASC_BYPASS_KEYCHAIN=1 make test` - Manual smoke (optional): run `asc validate`, `asc validate testflight`, `asc validate iap`, `asc validate subscriptions` against a real app. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>