[PR #628] [MERGED] Missing apps relationship endpoints #660

New issue

Closed

opened 2026-02-26 22:32:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:32:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/628
Author: @rudrankriyam
Created: 2/18/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/missing-apps-relationship-endpoints-0866

📝 Commits (2)

7eba9c3 coverage: add apps relationship linkages endpoints
728b959 fix: align apps relationships with production

📊 Changes

3 files changed (+695 additions, -0 deletions)

View changed files

➕ internal/asc/client_apps_relationships.go (+296 -0)
➕ internal/asc/client_http_apps_relationships_test.go (+341 -0)
📝 internal/cli/cmdtest/release_notes_generate_test.go (+58 -0)

📄 Description

Summary

Implements 35 missing /v1/apps/{id}/relationships/* GET endpoints for App Store Connect API.

Adds new client methods in internal/asc/client_apps_relationships.go.
Utilizes a shared helper for to-many relationships and distinct response structs for to-one relationships.
Includes comprehensive request-shaping tests for each new endpoint in internal/asc/client_http_apps_relationships_test.go.

Validation

make format
make lint
make test (specifically ASC_BYPASS_KEYCHAIN=1 make test passes)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/628 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/18/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/missing-apps-relationship-endpoints-0866` --- ### 📝 Commits (2) - [`7eba9c3`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/7eba9c37f4d62c6039f0ba80554027eab3a1dbee) coverage: add apps relationship linkages endpoints - [`728b959`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/728b959d3e1e883f11e1ffe24d4d5a146760074b) fix: align apps relationships with production ### 📊 Changes **3 files changed** (+695 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `internal/asc/client_apps_relationships.go` (+296 -0) ➕ `internal/asc/client_http_apps_relationships_test.go` (+341 -0) 📝 `internal/cli/cmdtest/release_notes_generate_test.go` (+58 -0) </details> ### 📄 Description ## Summary Implements 35 missing `/v1/apps/{id}/relationships/*` GET endpoints for App Store Connect API. - Adds new client methods in `internal/asc/client_apps_relationships.go`. - Utilizes a shared helper for to-many relationships and distinct response structs for to-one relationships. - Includes comprehensive request-shaping tests for each new endpoint in `internal/asc/client_http_apps_relationships_test.go`. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` (specifically `ASC_BYPASS_KEYCHAIN=1 make test` passes) --- <p><a href="https://cursor.com/background-agent?bcId=bc-004fcc84-9b49-4715-9ba2-bd1b682a6bc1"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-004fcc84-9b49-4715-9ba2-bd1b682a6bc1"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>