[PR #572] [MERGED] Shared safe-write utility #628

New issue

Closed

opened 2026-02-26 22:31:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/572
Author: @cursor[bot]
Created: 2/16/2026
Status: ✅ Merged
Merged: 2/16/2026
Merged by: @rudrankriyam

Base: certificates/csr-generate ← Head: cursor/shared-safe-write-utility-eab2

📝 Commits (1)

8c5be6e shared: dedupe safe file write logic

📊 Changes

3 files changed (+133 additions, -189 deletions)

View changed files

📝 internal/cli/assets/assets_download_helpers.go (+10 -98)
📝 internal/cli/certificates/csr.go (+12 -91)
➕ internal/cli/shared/safe_write.go (+111 -0)

📄 Description

Summary

Refactored duplicated safe-write file logic from assets_download_helpers.go and csr.go into a new shared utility function shared.WriteFileNoSymlink to reduce code duplication and improve maintainability.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/572 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/16/2026 **Status:** ✅ Merged **Merged:** 2/16/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `certificates/csr-generate` ← **Head:** `cursor/shared-safe-write-utility-eab2` --- ### 📝 Commits (1) - [`8c5be6e`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/8c5be6e765913bd7e6a5486aa8b71379c5990567) shared: dedupe safe file write logic ### 📊 Changes **3 files changed** (+133 additions, -189 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/assets/assets_download_helpers.go` (+10 -98) 📝 `internal/cli/certificates/csr.go` (+12 -91) ➕ `internal/cli/shared/safe_write.go` (+111 -0) </details> ### 📄 Description ## Summary - Refactored duplicated safe-write file logic from `assets_download_helpers.go` and `csr.go` into a new shared utility function `shared.WriteFileNoSymlink` to reduce code duplication and improve maintainability. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>