[PR #613] [MERGED] Pr 612 review #656

New issue

Closed

opened 2026-02-26 22:31:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/613
Author: @rudrankriyam
Created: 2/17/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/pr-612-review-4cbe

📝 Commits (5)

9b3d70e fix: skip non-locale directories in fastlane metadata import
6e5ee77 fix: report skipped non-locale metadata dirs
b65d683 cmdtest: fix path comparison in migrate import test
8e3c531 Merge pull request #614 from rudrankriyam/cursor/macos-test-path-comparison-c5a7
8900e06 Merge main into PR branch

📊 Changes

3 files changed (+205 additions, -93 deletions)

View changed files

📝 internal/cli/cmdtest/migrate_import_test.go (+77 -0)
📝 internal/cli/migrate/migrate.go (+105 -93)
📝 internal/cli/migrate/migrate_output.go (+23 -0)

📄 Description

Summary

Addresses silent skipping of non-locale fastlane/metadata/ subdirectories by reporting them in the skipped[] list for asc migrate import --dry-run and asc migrate validate. This ensures users are aware of any directories that could not be processed, including genuinely mistyped locale folders.
Adds cmdtest coverage to verify the reporting of skipped directories.

Validation

make format
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/613 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/17/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/pr-612-review-4cbe` --- ### 📝 Commits (5) - [`9b3d70e`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/9b3d70e3767b95c4f5dd56acfb7ee409bb6d912e) fix: skip non-locale directories in fastlane metadata import - [`6e5ee77`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6e5ee7734296bae75273cbaad9b03392ef257f14) fix: report skipped non-locale metadata dirs - [`b65d683`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b65d683835bb495e339b0e057165a103d1e574fd) cmdtest: fix path comparison in migrate import test - [`8e3c531`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/8e3c531895368e7c17c9f121ff39a8d3d054d36c) Merge pull request #614 from rudrankriyam/cursor/macos-test-path-comparison-c5a7 - [`8900e06`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/8900e06ab24a79dcd4529f947d37a1337281a429) Merge main into PR branch ### 📊 Changes **3 files changed** (+205 additions, -93 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/cmdtest/migrate_import_test.go` (+77 -0) 📝 `internal/cli/migrate/migrate.go` (+105 -93) 📝 `internal/cli/migrate/migrate_output.go` (+23 -0) </details> ### 📄 Description ## Summary - Addresses silent skipping of non-locale `fastlane/metadata/` subdirectories by reporting them in the `skipped[]` list for `asc migrate import --dry-run` and `asc migrate validate`. This ensures users are aware of any directories that could not be processed, including genuinely mistyped locale folders. - Adds cmdtest coverage to verify the reporting of skipped directories. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` --- <p><a href="https://cursor.com/background-agent?bcId=bc-72ea6754-dcfa-4e3c-b839-1c929af8db3e"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-72ea6754-dcfa-4e3c-b839-1c929af8db3e"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>