[PR #550] [CLOSED] Update check completion #613

New issue

Closed

opened 2026-02-26 22:31:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/550
Author: @cursor[bot]
Created: 2/14/2026
Status: ❌ Closed

Base: main ← Head: cursor/update-check-completion-5af0

📝 Commits (1)

57eb5e8 Wait for async update check before process exit

📊 Changes

2 files changed (+35 additions, -12 deletions)

View changed files

📝 cmd/run.go (+15 -2)
📝 cmd/run_additional_test.go (+20 -10)

📄 Description

Summary

Fixed a bug where the asynchronous update check goroutine could be prematurely terminated on fast CLI commands, preventing update metadata from being cached. A sync.WaitGroup is now used to ensure the update check completes before the program exits.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/550 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `cursor/update-check-completion-5af0` --- ### 📝 Commits (1) - [`57eb5e8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/57eb5e8acc17e7f2b68bc7154ec131065e587210) Wait for async update check before process exit ### 📊 Changes **2 files changed** (+35 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `cmd/run.go` (+15 -2) 📝 `cmd/run_additional_test.go` (+20 -10) </details> ### 📄 Description ## Summary - Fixed a bug where the asynchronous update check goroutine could be prematurely terminated on fast CLI commands, preventing update metadata from being cached. A `sync.WaitGroup` is now used to ensure the update check completes before the program exits. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>