[PR #612] [MERGED] Fix: skip non-locale directories in fastlane metadata import #654

New issue

Closed

opened 2026-02-26 22:31:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/612
Author: @cameronehrlich
Created: 2/17/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @rudrankriyam

Base: main ← Head: fix/skip-non-locale-metadata-dirs

📝 Commits (1)

5033310 fix: skip non-locale directories in fastlane metadata import

📊 Changes

2 files changed (+66 additions, -2 deletions)

View changed files

📝 internal/cli/migrate/migrate.go (+2 -2)
📝 internal/cli/migrate/migrate_test.go (+64 -0)

📄 Description

Summary

asc migrate import fails when fastlane/metadata/ contains non-locale subdirectories like trade_representative_contact_information
Instead of returning an error when normalizeLocale() rejects a directory name, both readFastlaneMetadata() and readFastlaneAppInfoMetadata() now skip it with continue
This handles any non-locale directory generically, not just the ones currently known

Changes

internal/cli/migrate/migrate.go: Changed error return to continue in both metadata reader functions
internal/cli/migrate/migrate_test.go: Added tests for both functions to verify non-locale directories are skipped

Test plan

New tests pass: TestReadFastlaneMetadata_SkipsNonLocaleDirectories and TestReadFastlaneAppInfoMetadata_SkipsNonLocaleDirectories
Existing tests unchanged and passing (including TestReadFastlaneMetadata_SkipsSpecialDirectories)
Full test suite passes (go test ./... — all 83 packages)

Fixes #611

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/612 **Author:** [@cameronehrlich](https://github.com/cameronehrlich) **Created:** 2/17/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `fix/skip-non-locale-metadata-dirs` --- ### 📝 Commits (1) - [`5033310`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/50333107b5938acb4282a4f3308f4dd961ab8ebb) fix: skip non-locale directories in fastlane metadata import ### 📊 Changes **2 files changed** (+66 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/migrate/migrate.go` (+2 -2) 📝 `internal/cli/migrate/migrate_test.go` (+64 -0) </details> ### 📄 Description ## Summary - `asc migrate import` fails when `fastlane/metadata/` contains non-locale subdirectories like `trade_representative_contact_information` - Instead of returning an error when `normalizeLocale()` rejects a directory name, both `readFastlaneMetadata()` and `readFastlaneAppInfoMetadata()` now skip it with `continue` - This handles any non-locale directory generically, not just the ones currently known ## Changes - `internal/cli/migrate/migrate.go`: Changed error return to `continue` in both metadata reader functions - `internal/cli/migrate/migrate_test.go`: Added tests for both functions to verify non-locale directories are skipped ## Test plan - [x] New tests pass: `TestReadFastlaneMetadata_SkipsNonLocaleDirectories` and `TestReadFastlaneAppInfoMetadata_SkipsNonLocaleDirectories` - [x] Existing tests unchanged and passing (including `TestReadFastlaneMetadata_SkipsSpecialDirectories`) - [x] Full test suite passes (`go test ./...` — all 83 packages) Fixes #611 🤖 Generated with [Claude Code](https://claude.ai/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>