[PR #547] [CLOSED] Registry and test issues #611

New issue

Closed

opened 2026-02-26 22:31:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/547
Author: @cursor[bot]
Created: 2/14/2026
Status: ❌ Closed

Base: cursor/appstoreconnectcli-async-await-f47d ← Head: cursor/registry-and-test-issues-df3e

📝 Commits (10+)

096f892 refactor: unify polling loops with shared helper
69d31a4 refactor: centralize secure open nofollow logic
111cfed perf: cache asc config loads in runtime resolvers
198a563 refactor: dedupe linkage output registry adapters
b004364 refactor(cli): add shared output flag binder
447fc78 refactor(asc): add generic output registry adapters
a7f58c8 refactor(asc): migrate more registry wrappers to adapters
1b54a7c refactor(cli): use output binder in shared command builders
1a76d70 refactor(cli): migrate pre-orders output flags binder
56da68f refactor(cli): migrate pre-release output flags binder

📊 Changes

75 files changed (+1227 additions, -1067 deletions)

View changed files

📝 internal/asc/client_core.go (+30 -4)
➕ internal/asc/client_core_config_cache_test.go (+81 -0)
📝 internal/asc/client_publish.go (+6 -14)
📝 internal/asc/output_registry.go (+7 -0)
📝 internal/asc/output_registry_init.go (+404 -400)
➕ internal/asc/poll.go (+52 -0)
➕ internal/asc/poll_test.go (+80 -0)
📝 internal/asc/secure_open_other.go (+6 -2)
📝 internal/asc/secure_open_unix.go (+2 -3)
📝 internal/cli/accessibility/accessibility.go (+11 -16)
📝 internal/cli/actors/actors.go (+5 -7)
📝 internal/cli/agerating/age_rating.go (+4 -6)
📝 internal/cli/agreements/agreements.go (+3 -4)
📝 internal/cli/analytics/analytics_instances.go (+5 -7)
📝 internal/cli/analytics/analytics_reports.go (+5 -7)
📝 internal/cli/analytics/analytics_requests.go (+9 -13)
📝 internal/cli/analytics/analytics_segments.go (+2 -3)
📝 internal/cli/androidiosmapping/android_ios_mapping.go (+11 -16)
📝 internal/cli/apps/apps.go (+10 -13)
📝 internal/cli/assets/assets_helpers.go (+13 -12)

...and 55 more files

📄 Description

Summary

Removed unused registerRowsErrAdapter function.
Added t.Cleanup to TestResetConfigCacheForTestReloadsConfig to ensure global config loader state is reset after the test.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/547 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/14/2026 **Status:** ❌ Closed **Base:** `cursor/appstoreconnectcli-async-await-f47d` ← **Head:** `cursor/registry-and-test-issues-df3e` --- ### 📝 Commits (10+) - [`096f892`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/096f892dc64c67d9a1c4939d5d434f85a8f8a099) refactor: unify polling loops with shared helper - [`69d31a4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/69d31a4fd05299ddd9bbb718d4c1b955da96be5f) refactor: centralize secure open nofollow logic - [`111cfed`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/111cfedb802e6c48f2ea22775d60334009ec5e08) perf: cache asc config loads in runtime resolvers - [`198a563`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/198a5634cf1ca435f6cf21be8497815bea5f42a4) refactor: dedupe linkage output registry adapters - [`b004364`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b0043640933d80fbf0b033b0d91811b965ef2a05) refactor(cli): add shared output flag binder - [`447fc78`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/447fc7866385593eb693219155c7637026eec35f) refactor(asc): add generic output registry adapters - [`a7f58c8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a7f58c8df9c2d948ee866feee4cf37c5e092ced4) refactor(asc): migrate more registry wrappers to adapters - [`1b54a7c`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/1b54a7c1490ebe5b0df7b3c91dae4a975448910f) refactor(cli): use output binder in shared command builders - [`1a76d70`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/1a76d70c71526bf2f44ac13ab5ddc44490da3103) refactor(cli): migrate pre-orders output flags binder - [`56da68f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/56da68f865b5a7b519ad45099d6941844903d40e) refactor(cli): migrate pre-release output flags binder ### 📊 Changes **75 files changed** (+1227 additions, -1067 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_core.go` (+30 -4) ➕ `internal/asc/client_core_config_cache_test.go` (+81 -0) 📝 `internal/asc/client_publish.go` (+6 -14) 📝 `internal/asc/output_registry.go` (+7 -0) 📝 `internal/asc/output_registry_init.go` (+404 -400) ➕ `internal/asc/poll.go` (+52 -0) ➕ `internal/asc/poll_test.go` (+80 -0) 📝 `internal/asc/secure_open_other.go` (+6 -2) 📝 `internal/asc/secure_open_unix.go` (+2 -3) 📝 `internal/cli/accessibility/accessibility.go` (+11 -16) 📝 `internal/cli/actors/actors.go` (+5 -7) 📝 `internal/cli/agerating/age_rating.go` (+4 -6) 📝 `internal/cli/agreements/agreements.go` (+3 -4) 📝 `internal/cli/analytics/analytics_instances.go` (+5 -7) 📝 `internal/cli/analytics/analytics_reports.go` (+5 -7) 📝 `internal/cli/analytics/analytics_requests.go` (+9 -13) 📝 `internal/cli/analytics/analytics_segments.go` (+2 -3) 📝 `internal/cli/androidiosmapping/android_ios_mapping.go` (+11 -16) 📝 `internal/cli/apps/apps.go` (+10 -13) 📝 `internal/cli/assets/assets_helpers.go` (+13 -12) _...and 55 more files_ </details> ### 📄 Description ## Summary - Removed unused `registerRowsErrAdapter` function. - Added `t.Cleanup` to `TestResetConfigCacheForTestReloadsConfig` to ensure global config loader state is reset after the test. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>