[PR #606] [MERGED] ci(lint): enable misspell linter (phase 1) #649

New issue

Closed

opened 2026-02-26 22:31:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/606
Author: @rudrankriyam
Created: 2/17/2026
Status: ✅ Merged
Merged: 2/17/2026
Merged by: @rudrankriyam

Base: main ← Head: ci/enable-misspell-linter

📝 Commits (1)

fbfd988 ci(lint): enable misspell linter (phase 1 of #602)

📊 Changes

1 file changed (+10 additions, -2 deletions)

View changed files

📝 .golangci.yml (+10 -2)

📄 Description

Summary

Enables the misspell golangci-lint linter as phase 1 of #602.
Adds ignore-words for Apple/ASC domain terms (cancelled, cancelling) to avoid false positives.
Config-only change — the codebase already has zero misspellings, so no code fixes needed.

Checks run

make lint — passes
ASC_BYPASS_KEYCHAIN=1 make test — passes

Closes phase 1 of #602.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/606 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/17/2026 **Status:** ✅ Merged **Merged:** 2/17/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `ci/enable-misspell-linter` --- ### 📝 Commits (1) - [`fbfd988`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/fbfd988ff485bf4acf8c4b842a764ac5ce59b0cc) ci(lint): enable misspell linter (phase 1 of #602) ### 📊 Changes **1 file changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.golangci.yml` (+10 -2) </details> ### 📄 Description ## Summary - Enables the `misspell` golangci-lint linter as phase 1 of #602. - Adds `ignore-words` for Apple/ASC domain terms (`cancelled`, `cancelling`) to avoid false positives. - Config-only change — the codebase already has zero misspellings, so no code fixes needed. ## Checks run - `make lint` — passes - `ASC_BYPASS_KEYCHAIN=1 make test` — passes Closes phase 1 of #602. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>