[PR #538] [MERGED] Screenshots watch and review #602

New issue

Closed

opened 2026-02-26 22:31:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/538
Author: @cursor[bot]
Created: 2/14/2026
Status: ✅ Merged
Merged: 2/14/2026
Merged by: @rudrankriyam

Base: feat/shots-capture-mvp ← Head: cursor/screenshots-watch-and-review-831a

📝 Commits (2)

560a40f Fix screenshot watch asset resolution and coalescing bugs
6e557e6 Merge remote-tracking branch 'origin/feat/shots-capture-mvp' into cursor/screenshots-watch-and-review-831a

📊 Changes

4 files changed (+191 additions, -3 deletions)

View changed files

📝 internal/screenshots/review.go (+5 -1)
📝 internal/screenshots/review_test.go (+38 -0)
📝 internal/screenshots/watch.go (+45 -2)
📝 internal/screenshots/watch_test.go (+103 -0)

📄 Description

Summary

Fixes an issue where shots frame --watch would miss relative asset changes by resolving asset paths relative to the config file's directory.
Corrects buildRawIndex to prevent unpredictable linking of framed images to raw sources when multiple raw files share the same screenshot ID.
Prevents concurrent kou generate runs in watch mode by ensuring only one generation process executes at a time.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/538 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/14/2026 **Status:** ✅ Merged **Merged:** 2/14/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/shots-capture-mvp` ← **Head:** `cursor/screenshots-watch-and-review-831a` --- ### 📝 Commits (2) - [`560a40f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/560a40f74474db2e68a3fa274739cbc72550e38c) Fix screenshot watch asset resolution and coalescing bugs - [`6e557e6`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6e557e696066372a2316becd994ca9c29793c109) Merge remote-tracking branch 'origin/feat/shots-capture-mvp' into cursor/screenshots-watch-and-review-831a ### 📊 Changes **4 files changed** (+191 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `internal/screenshots/review.go` (+5 -1) 📝 `internal/screenshots/review_test.go` (+38 -0) 📝 `internal/screenshots/watch.go` (+45 -2) 📝 `internal/screenshots/watch_test.go` (+103 -0) </details> ### 📄 Description ## Summary - Fixes an issue where `shots frame --watch` would miss relative asset changes by resolving asset paths relative to the config file's directory. - Corrects `buildRawIndex` to prevent unpredictable linking of framed images to raw sources when multiple raw files share the same screenshot ID. - Prevents concurrent `kou generate` runs in watch mode by ensuring only one generation process executes at a time. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>