[PR #601] [MERGED] chore: lowercase error strings (staticcheck ST1005) #644

New issue

Closed

opened 2026-02-26 22:31:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/601
Author: @rudrankriyam
Created: 2/17/2026
Status: ✅ Merged
Merged: 2/17/2026
Merged by: @rudrankriyam

Base: main ← Head: chore/fix-st1005-error-strings

📝 Commits (5)

44bd4bb chore: lowercase error strings for staticcheck
77625fe chore(ci): add golangci-lint baseline config
108a72b chore: keep Info.plist casing in errors
c9ae78f chore(ci): restore golangci-lint issue limits
d26faa5 Revert "chore(ci): restore golangci-lint issue limits"

📊 Changes

5 files changed (+33 additions, -5 deletions)

View changed files

➕ .golangci.yml (+27 -0)
📝 internal/asc/client_pagination.go (+2 -2)
📝 internal/cli/builds/builds_commands.go (+1 -1)
📝 internal/cli/publish/publish.go (+1 -1)
📝 internal/cli/shared/ipa.go (+2 -1)

📄 Description

Fix staticcheck/stylecheck ST1005 warnings by ensuring error strings don't start with capital letters.

Changes

internal/asc/client_pagination.go: "data field ..." errors
internal/cli/publish/publish.go: "info.plist missing ..." error
internal/cli/shared/ipa.go: "info.plist not found in IPA" error

Verification

make format
make lint
staticcheck ./...
ASC_BYPASS_KEYCHAIN=1 make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/601 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/17/2026 **Status:** ✅ Merged **Merged:** 2/17/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `chore/fix-st1005-error-strings` --- ### 📝 Commits (5) - [`44bd4bb`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/44bd4bbd9341c8d752667d074fac7affc54704e7) chore: lowercase error strings for staticcheck - [`77625fe`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/77625fe4aecf0708224542578abaf90e0ce0fc4c) chore(ci): add golangci-lint baseline config - [`108a72b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/108a72b563da8309e67da5a864b96c162741d407) chore: keep Info.plist casing in errors - [`c9ae78f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/c9ae78fd75b8e37442ede033ff1eed6198374633) chore(ci): restore golangci-lint issue limits - [`d26faa5`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d26faa5e5710525b9944a83632705e7c2be88eb0) Revert "chore(ci): restore golangci-lint issue limits" ### 📊 Changes **5 files changed** (+33 additions, -5 deletions) <details> <summary>View changed files</summary> ➕ `.golangci.yml` (+27 -0) 📝 `internal/asc/client_pagination.go` (+2 -2) 📝 `internal/cli/builds/builds_commands.go` (+1 -1) 📝 `internal/cli/publish/publish.go` (+1 -1) 📝 `internal/cli/shared/ipa.go` (+2 -1) </details> ### 📄 Description Fix staticcheck/stylecheck ST1005 warnings by ensuring error strings don't start with capital letters. Changes - `internal/asc/client_pagination.go`: "data field ..." errors - `internal/cli/publish/publish.go`: "info.plist missing ..." error - `internal/cli/shared/ipa.go`: "info.plist not found in IPA" error Verification - `make format` - `make lint` - `staticcheck ./...` - `ASC_BYPASS_KEYCHAIN=1 make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>