[PR #537] [MERGED] Path and URL resolution #601

New issue

Closed

opened 2026-02-26 22:31:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/537
Author: @cursor[bot]
Created: 2/14/2026
Status: ✅ Merged
Merged: 2/14/2026
Merged by: @rudrankriyam

Base: feat/shots-capture-mvp ← Head: cursor/path-and-url-resolution-3ff0

📝 Commits (1)

f89fc43 Fix shots frame name traversal and Windows review URL paths

📊 Changes

4 files changed (+55 additions, -1 deletions)

View changed files

📝 internal/cli/shots/shots_frame.go (+3 -0)
📝 internal/cli/shots/shots_frame_test.go (+24 -0)
📝 internal/screenshots/review.go (+12 -1)
📝 internal/screenshots/review_test.go (+16 -0)

📄 Description

Summary

Fixed a path traversal vulnerability in shots frame --name by sanitizing the input to prevent writing files outside the intended output directory.
Corrected the generation of file:// URLs for local images in the review workflow on Windows to ensure they load correctly.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I edited docs/wall-of-apps.json (not the generated Wall block in README.md directly)
I ran make update-wall-of-apps
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/537 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/14/2026 **Status:** ✅ Merged **Merged:** 2/14/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/shots-capture-mvp` ← **Head:** `cursor/path-and-url-resolution-3ff0` --- ### 📝 Commits (1) - [`f89fc43`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/f89fc4399213cd0e7ba200336f0d91c9ebd7133e) Fix shots frame name traversal and Windows review URL paths ### 📊 Changes **4 files changed** (+55 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/shots/shots_frame.go` (+3 -0) 📝 `internal/cli/shots/shots_frame_test.go` (+24 -0) 📝 `internal/screenshots/review.go` (+12 -1) 📝 `internal/screenshots/review_test.go` (+16 -0) </details> ### 📄 Description ## Summary - Fixed a path traversal vulnerability in `shots frame --name` by sanitizing the input to prevent writing files outside the intended output directory. - Corrected the generation of `file://` URLs for local images in the review workflow on Windows to ensure they load correctly. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I edited `docs/wall-of-apps.json` (not the generated Wall block in `README.md` directly) - [ ] I ran `make update-wall-of-apps` - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>