[PR #556] [MERGED] V1.0 whatsNew validation #618

New issue

Closed

opened 2026-02-26 22:31:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/556
Author: @rudrankriyam
Created: 2/15/2026
Status: ✅ Merged
Merged: 2/15/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/v1-0-whatsnew-validation-17f2

📝 Commits (1)

6ad91df validate: skip whatsNew warning on initial releases

📊 Changes

4 files changed (+118 additions, -6 deletions)

View changed files

📝 internal/cli/cmdtest/validate_test.go (+40 -0)
📝 internal/validation/report.go (+1 -1)
📝 internal/validation/required_fields.go (+51 -3)
📝 internal/validation/required_fields_test.go (+26 -2)

📄 Description

Summary

asc validate no longer warns about an empty whatsNew field for initial 1.0 releases (e.g., 1.0, 1.0.0).
This prevents --strict validation from failing solely due to the "What's New is empty" warning on first submissions.
Added unit and CLI regression tests to confirm the new behavior.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/556 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/15/2026 **Status:** ✅ Merged **Merged:** 2/15/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/v1-0-whatsnew-validation-17f2` --- ### 📝 Commits (1) - [`6ad91df`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6ad91df879ac05b5ac98631a2348bf8337be9bc3) validate: skip whatsNew warning on initial releases ### 📊 Changes **4 files changed** (+118 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/cmdtest/validate_test.go` (+40 -0) 📝 `internal/validation/report.go` (+1 -1) 📝 `internal/validation/required_fields.go` (+51 -3) 📝 `internal/validation/required_fields_test.go` (+26 -2) </details> ### 📄 Description ## Summary - `asc validate` no longer warns about an empty `whatsNew` field for initial `1.0` releases (e.g., `1.0`, `1.0.0`). - This prevents `--strict` validation from failing solely due to the "What's New is empty" warning on first submissions. - Added unit and CLI regression tests to confirm the new behavior. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- <p><a href="https://cursor.com/background-agent?bcId=bc-6c563ad8-8f4b-4f1f-9f1b-954c2742ecd5"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-6c563ad8-8f4b-4f1f-9f1b-954c2742ecd5"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>