[PR #475] [MERGED] Global flag app ID check #556

New issue

Closed

opened 2026-02-26 22:31:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/475
Author: @cursor[bot]
Created: 2/10/2026
Status: ✅ Merged
Merged: 2/10/2026
Merged by: @rudrankriyam

Base: cursor/global-list-endpoints-parity-1a34 ← Head: cursor/global-flag-app-id-check-768e

📝 Commits (2)

42121d3 Fix --global flag broken when ASC_APP_ID env var is set
84d9f53 test: add ASC_APP_ID global-flag regression coverage

📊 Changes

4 files changed (+94 additions, -4 deletions)

View changed files

📝 internal/cli/cmdtest/beta_groups_global_test.go (+45 -0)
📝 internal/cli/cmdtest/review_submissions_global_test.go (+45 -0)
📝 internal/cli/reviews/review_submissions.go (+2 -2)
📝 internal/cli/testflight/beta_groups.go (+2 -2)

📄 Description

Fix --global flag being broken when ASC_APP_ID environment variable is set.

The previous mutual exclusivity check for --global and --app incorrectly used the resolved application ID, which includes values from environment variables or config files. This led to an error when --global was used, even if --app was not explicitly passed, making --global unusable in configured environments.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/475 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/10/2026 **Status:** ✅ Merged **Merged:** 2/10/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `cursor/global-list-endpoints-parity-1a34` ← **Head:** `cursor/global-flag-app-id-check-768e` --- ### 📝 Commits (2) - [`42121d3`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/42121d39e82f9aab4049c9fb32a2ea3ea1797b20) Fix --global flag broken when ASC_APP_ID env var is set - [`84d9f53`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/84d9f53cce9e9002a986575a3422fc532b150d6b) test: add ASC_APP_ID global-flag regression coverage ### 📊 Changes **4 files changed** (+94 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/cmdtest/beta_groups_global_test.go` (+45 -0) 📝 `internal/cli/cmdtest/review_submissions_global_test.go` (+45 -0) 📝 `internal/cli/reviews/review_submissions.go` (+2 -2) 📝 `internal/cli/testflight/beta_groups.go` (+2 -2) </details> ### 📄 Description Fix `--global` flag being broken when `ASC_APP_ID` environment variable is set. The previous mutual exclusivity check for `--global` and `--app` incorrectly used the resolved application ID, which includes values from environment variables or config files. This led to an error when `--global` was used, even if `--app` was not explicitly passed, making `--global` unusable in configured environments. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>