[PR #552] [MERGED] PR 551 generation issue #615

New issue

Closed

opened 2026-02-26 22:31:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/552
Author: @rudrankriyam
Created: 2/15/2026
Status: ✅ Merged
Merged: 2/15/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/pr-551-generation-issue-69e0

📝 Commits (7)

b342df5 feat(wall): add make generate app flow and sync dandelion entry
94159a8 Merge remote-tracking branch 'origin/main' into cursor/pr-551-generation-issue-69e0
486ba71 fix(wall): resolve duplicate dandelion row after main merge
966d0d2 Share wall entry type between wallgen and generate-app
a893ffa Merge pull request #553 from rudrankriyam/cursor/wallentry-struct-duplication-10fa
eddb3ae refactor(wall): remove WallEntry type aliases and use exported type directly
07b449e fix(generate-app): roll back JSON when README sync fails

📊 Changes

8 files changed (+517 additions, -18 deletions)

View changed files

📝 .github/PULL_REQUEST_TEMPLATE.md (+1 -2)
📝 CONTRIBUTING.md (+4 -2)
📝 Makefile (+15 -0)
📝 README.md (+8 -1)
📝 docs/wall-of-apps.json (+6 -0)
📝 internal/wallgen/wallgen.go (+14 -13)
➕ tools/generate-app/main.go (+250 -0)
➕ tools/generate-app/main_test.go (+219 -0)

📄 Description

Summary

Introduces make generate app to standardize Wall of Apps additions, resolving CI failures caused by manual README.md edits (e.g., Dandelion app in #551). This ensures all Wall entries are managed through docs/wall-of-apps.json.
Adds the Dandelion app using the new make generate app workflow.
Updates contributor guidelines and PR template to reflect the new generation process.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="Dandelion" LINK="https://apps.apple.com/us/app/dandelion-write-and-let-go/id6757363901" CREATOR="joeycast" PLATFORM="iOS,macOS"
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Dandelion",
  "link": "https://apps.apple.com/us/app/dandelion-write-and-let-go/id6757363901",
  "creator": "joeycast",
  "platform": ["iOS", "macOS"]
}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/552 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/15/2026 **Status:** ✅ Merged **Merged:** 2/15/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/pr-551-generation-issue-69e0` --- ### 📝 Commits (7) - [`b342df5`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b342df56be6580bd8a2b89cbc098907a91a384a5) feat(wall): add make generate app flow and sync dandelion entry - [`94159a8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/94159a8ce82e8dc68ce75a03f03bf7ef9e9a9312) Merge remote-tracking branch 'origin/main' into cursor/pr-551-generation-issue-69e0 - [`486ba71`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/486ba715e38fc625266dca0857e6102a6abeac80) fix(wall): resolve duplicate dandelion row after main merge - [`966d0d2`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/966d0d253cdf3d30b8a6b1c4881d1ce199eb6875) Share wall entry type between wallgen and generate-app - [`a893ffa`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a893ffa43bb740a7bfff599b5317cf73624a9d32) Merge pull request #553 from rudrankriyam/cursor/wallentry-struct-duplication-10fa - [`eddb3ae`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/eddb3ae58b4edf97f6996b48d73f3fd9439439a9) refactor(wall): remove WallEntry type aliases and use exported type directly - [`07b449e`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/07b449edf95fc0c6865eb3c17d7908cf9500e01a) fix(generate-app): roll back JSON when README sync fails ### 📊 Changes **8 files changed** (+517 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `.github/PULL_REQUEST_TEMPLATE.md` (+1 -2) 📝 `CONTRIBUTING.md` (+4 -2) 📝 `Makefile` (+15 -0) 📝 `README.md` (+8 -1) 📝 `docs/wall-of-apps.json` (+6 -0) 📝 `internal/wallgen/wallgen.go` (+14 -13) ➕ `tools/generate-app/main.go` (+250 -0) ➕ `tools/generate-app/main_test.go` (+219 -0) </details> ### 📄 Description ## Summary - Introduces `make generate app` to standardize Wall of Apps additions, resolving CI failures caused by manual `README.md` edits (e.g., Dandelion app in #551). This ensures all Wall entries are managed through `docs/wall-of-apps.json`. - Adds the Dandelion app using the new `make generate app` workflow. - Updates contributor guidelines and PR template to reflect the new generation process. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [x] I ran `make generate app APP="Dandelion" LINK="https://apps.apple.com/us/app/dandelion-write-and-let-go/id6757363901" CREATOR="joeycast" PLATFORM="iOS,macOS"` - [x] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Dandelion", "link": "https://apps.apple.com/us/app/dandelion-write-and-let-go/id6757363901", "creator": "joeycast", "platform": ["iOS", "macOS"] } ``` --- <p><a href="https://cursor.com/background-agent?bcId=bc-3f93eb39-8064-4919-83f0-fc57da42d60e"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-3f93eb39-8064-4919-83f0-fc57da42d60e"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>