[PR #473] [MERGED] Global list endpoints parity #552

New issue

Closed

opened 2026-02-26 22:31:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/473
Author: @rudrankriyam
Created: 2/10/2026
Status: ✅ Merged
Merged: 2/10/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/global-list-endpoints-parity-1a34

📝 Commits (6)

5320f44 feat: add global list client methods and --global flag for beta groups, beta build localizations, review submissions
c98de8b test: add comprehensive tests for global list endpoints
42121d3 Fix --global flag broken when ASC_APP_ID env var is set
84d9f53 test: add ASC_APP_ID global-flag regression coverage
f9ffefb Merge pull request #475 from rudrankriyam/cursor/global-flag-app-id-check-768e
d2b4eda fix: require app filter for top-level review submissions list

📊 Changes

14 files changed (+1286 additions, -21 deletions)

View changed files

📝 internal/asc/client.go (+60 -0)
📝 internal/asc/client_http_test.go (+195 -0)
📝 internal/asc/client_options.go (+7 -0)
📝 internal/asc/client_queries.go (+2 -0)
📝 internal/asc/review_submissions.go (+31 -0)
📝 internal/cli/betabuildlocalizations/beta_build_localizations.go (+43 -5)
➕ internal/cli/cmdtest/beta_build_localizations_global_test.go (+241 -0)
➕ internal/cli/cmdtest/beta_groups_global_test.go (+268 -0)
📝 internal/cli/cmdtest/builds_parity_test.go (+2 -2)
📝 internal/cli/cmdtest/commands_test.go (+2 -2)
➕ internal/cli/cmdtest/review_submissions_global_test.go (+344 -0)
📝 internal/cli/cmdtest/review_submissions_test.go (+2 -2)
📝 internal/cli/reviews/review_submissions.go (+45 -5)
📝 internal/cli/testflight/beta_groups.go (+44 -5)

📄 Description

Add global list support for beta groups, beta build localizations, and review submissions to provide parity with the App Store Connect API.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/473 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/10/2026 **Status:** ✅ Merged **Merged:** 2/10/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/global-list-endpoints-parity-1a34` --- ### 📝 Commits (6) - [`5320f44`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/5320f44b84932d5d17f21343f1f2ea48f1346c15) feat: add global list client methods and --global flag for beta groups, beta build localizations, review submissions - [`c98de8b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/c98de8b9122e19bc0b28bca7b56cf54922a1178c) test: add comprehensive tests for global list endpoints - [`42121d3`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/42121d39e82f9aab4049c9fb32a2ea3ea1797b20) Fix --global flag broken when ASC_APP_ID env var is set - [`84d9f53`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/84d9f53cce9e9002a986575a3422fc532b150d6b) test: add ASC_APP_ID global-flag regression coverage - [`f9ffefb`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/f9ffefb5219e11d48e71524f4f3f7f247ccda947) Merge pull request #475 from rudrankriyam/cursor/global-flag-app-id-check-768e - [`d2b4eda`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d2b4edaf6383d79d1c748ef26c1bea62f8c14dd7) fix: require app filter for top-level review submissions list ### 📊 Changes **14 files changed** (+1286 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client.go` (+60 -0) 📝 `internal/asc/client_http_test.go` (+195 -0) 📝 `internal/asc/client_options.go` (+7 -0) 📝 `internal/asc/client_queries.go` (+2 -0) 📝 `internal/asc/review_submissions.go` (+31 -0) 📝 `internal/cli/betabuildlocalizations/beta_build_localizations.go` (+43 -5) ➕ `internal/cli/cmdtest/beta_build_localizations_global_test.go` (+241 -0) ➕ `internal/cli/cmdtest/beta_groups_global_test.go` (+268 -0) 📝 `internal/cli/cmdtest/builds_parity_test.go` (+2 -2) 📝 `internal/cli/cmdtest/commands_test.go` (+2 -2) ➕ `internal/cli/cmdtest/review_submissions_global_test.go` (+344 -0) 📝 `internal/cli/cmdtest/review_submissions_test.go` (+2 -2) 📝 `internal/cli/reviews/review_submissions.go` (+45 -5) 📝 `internal/cli/testflight/beta_groups.go` (+44 -5) </details> ### 📄 Description Add global list support for beta groups, beta build localizations, and review submissions to provide parity with the App Store Connect API. --- <p><a href="https://cursor.com/background-agent?bcId=bc-333c08e3-3766-412c-ad29-95771d0a49cf"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-333c08e3-3766-412c-ad29-95771d0a49cf"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>