[PR #543] [MERGED] chore(cli): remove dead command wrappers and dedupe selection parsing #607

New issue

Closed

opened 2026-02-26 22:31:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/543
Author: @rudrankriyam
Created: 2/14/2026
Status: ✅ Merged
Merged: 2/14/2026
Merged by: @rudrankriyam

Base: main ← Head: chore/remove-dead-command-wrappers

📝 Commits (1)

0fba41c chore(cli): remove dead command wrappers and dedupe selection parsing

📊 Changes

92 files changed (+154 additions, -637 deletions)

View changed files

📝 internal/cli/accessibility/accessibility_test.go (+1 -1)
➖ internal/cli/accessibility/commands.go (+0 -8)
📝 internal/cli/actors/actors_test.go (+1 -1)
➖ internal/cli/actors/commands.go (+0 -8)
📝 internal/cli/agerating/age_rating_test.go (+1 -1)
➖ internal/cli/agerating/commands.go (+0 -8)
➖ internal/cli/analytics/commands.go (+0 -8)
📝 internal/cli/appclips/app_clips_test.go (+1 -1)
➖ internal/cli/appclips/commands.go (+0 -8)
📝 internal/cli/apps/app_info_include.go (+2 -24)
➖ internal/cli/apps/commands.go (+0 -8)
📝 internal/cli/apps/helpers_normalization_test.go (+6 -2)
📝 internal/cli/auth/auth_test.go (+3 -3)
➖ internal/cli/auth/commands.go (+0 -8)
➖ internal/cli/backgroundassets/commands.go (+0 -8)
📝 internal/cli/betaapplocalizations/beta_app_localizations_test.go (+1 -1)
➖ internal/cli/betaapplocalizations/commands.go (+0 -8)
📝 internal/cli/betabuildlocalizations/beta_build_localizations_test.go (+1 -1)
➖ internal/cli/betabuildlocalizations/commands.go (+0 -8)
📝 internal/cli/buildbundles/build_bundles_test.go (+1 -1)

...and 72 more files

📄 Description

Summary

delete 51 unreferenced internal/cli/*/commands.go passthrough files and remove unreferenced screenshots.Command() / videopreviews.Command() wrappers
move required constructors into their main package files (NotarizationCommand() and ValidateCommand()) so registry/test imports stay stable after wrapper-file removal
centralize repeated include/field normalization via shared.NormalizeSelection(...) and update affected tests/call sites to use direct constructors

Test plan

make format
make lint
ASC_BYPASS_KEYCHAIN=1 make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/543 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/14/2026 **Status:** ✅ Merged **Merged:** 2/14/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `chore/remove-dead-command-wrappers` --- ### 📝 Commits (1) - [`0fba41c`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/0fba41c3bd5b752a806a04fdb46a94d5836075dc) chore(cli): remove dead command wrappers and dedupe selection parsing ### 📊 Changes **92 files changed** (+154 additions, -637 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/accessibility/accessibility_test.go` (+1 -1) ➖ `internal/cli/accessibility/commands.go` (+0 -8) 📝 `internal/cli/actors/actors_test.go` (+1 -1) ➖ `internal/cli/actors/commands.go` (+0 -8) 📝 `internal/cli/agerating/age_rating_test.go` (+1 -1) ➖ `internal/cli/agerating/commands.go` (+0 -8) ➖ `internal/cli/analytics/commands.go` (+0 -8) 📝 `internal/cli/appclips/app_clips_test.go` (+1 -1) ➖ `internal/cli/appclips/commands.go` (+0 -8) 📝 `internal/cli/apps/app_info_include.go` (+2 -24) ➖ `internal/cli/apps/commands.go` (+0 -8) 📝 `internal/cli/apps/helpers_normalization_test.go` (+6 -2) 📝 `internal/cli/auth/auth_test.go` (+3 -3) ➖ `internal/cli/auth/commands.go` (+0 -8) ➖ `internal/cli/backgroundassets/commands.go` (+0 -8) 📝 `internal/cli/betaapplocalizations/beta_app_localizations_test.go` (+1 -1) ➖ `internal/cli/betaapplocalizations/commands.go` (+0 -8) 📝 `internal/cli/betabuildlocalizations/beta_build_localizations_test.go` (+1 -1) ➖ `internal/cli/betabuildlocalizations/commands.go` (+0 -8) 📝 `internal/cli/buildbundles/build_bundles_test.go` (+1 -1) _...and 72 more files_ </details> ### 📄 Description ## Summary - delete 51 unreferenced `internal/cli/*/commands.go` passthrough files and remove unreferenced `screenshots.Command()` / `videopreviews.Command()` wrappers - move required constructors into their main package files (`NotarizationCommand()` and `ValidateCommand()`) so registry/test imports stay stable after wrapper-file removal - centralize repeated include/field normalization via `shared.NormalizeSelection(...)` and update affected tests/call sites to use direct constructors ## Test plan - [x] `make format` - [x] `make lint` - [x] `ASC_BYPASS_KEYCHAIN=1 make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>