[PR #460] [MERGED] Exit codes, junit report #543

New issue

Closed

opened 2026-02-26 22:31:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/460
Author: @cursor[bot]
Created: 2/9/2026
Status: ✅ Merged
Merged: 2/9/2026
Merged by: @rudrankriyam

Base: ci-exit-codes ← Head: cursor/exit-codes-junit-report-cb9c

📝 Commits (1)

e7f2ed5 Fix unused exit code constants and unclosed XML encoder

📊 Changes

2 files changed (+4 additions, -2 deletions)

View changed files

📝 cmd/exit_codes.go (+1 -2)
📝 internal/cli/shared/junit_report.go (+3 -0)

📄 Description

Remove misleading HTTP exit code constants and ensure the JUnit XML encoder is closed.

The ExitHTTPNotFound and ExitHTTPConflict constants were removed as they were never returned by HTTPStatusToExitCode due to special-casing, leading to a misleading API. The xml.Encoder in MarshalXML is now explicitly closed to prevent potential truncation of JUnit XML output.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/460 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/9/2026 **Status:** ✅ Merged **Merged:** 2/9/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `ci-exit-codes` ← **Head:** `cursor/exit-codes-junit-report-cb9c` --- ### 📝 Commits (1) - [`e7f2ed5`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/e7f2ed56f2febb24482d28a5e22cefd59ec6920f) Fix unused exit code constants and unclosed XML encoder ### 📊 Changes **2 files changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `cmd/exit_codes.go` (+1 -2) 📝 `internal/cli/shared/junit_report.go` (+3 -0) </details> ### 📄 Description Remove misleading HTTP exit code constants and ensure the JUnit XML encoder is closed. The `ExitHTTPNotFound` and `ExitHTTPConflict` constants were removed as they were never returned by `HTTPStatusToExitCode` due to special-casing, leading to a misleading API. The `xml.Encoder` in `MarshalXML` is now explicitly closed to prevent potential truncation of JUnit XML output. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>