[PR #497] [MERGED] Metadata validation and helpers #571

New issue

Closed

opened 2026-02-26 22:31:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/497
Author: @cursor[bot]
Created: 2/11/2026
Status: ✅ Merged
Merged: 2/11/2026
Merged by: @rudrankriyam

Base: cursor/asc-pre-submission-validation-d668 ← Head: cursor/metadata-validation-and-helpers-cfb0

📝 Commits (1)

68939d8 Fix migrate length validation and helper visibility

📊 Changes

2 files changed (+26 additions, -19 deletions)

View changed files

📝 internal/cli/migrate/migrate.go (+19 -12)
📝 internal/cli/shared/app_info_helpers.go (+7 -7)

📄 Description

Summary

Aligned character counting in migrate validation functions (validateVersionLocalization, validateAppInfoLocalization) with metadata.go by switching from len() (byte count) to utf8.RuneCountInString() (rune count) for shared metadata limits, resolving inconsistencies for multi-byte UTF-8 content.
Unexported internal helper functions IsNonLiveAppInfoState and AppInfoAttrString in internal/cli/shared/app_info_helpers.go to reduce the public API surface, as they are only used within their own file.

Validation

make format
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/497 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/11/2026 **Status:** ✅ Merged **Merged:** 2/11/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `cursor/asc-pre-submission-validation-d668` ← **Head:** `cursor/metadata-validation-and-helpers-cfb0` --- ### 📝 Commits (1) - [`68939d8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/68939d83bb3df7789b8794335a86391bce20d3c9) Fix migrate length validation and helper visibility ### 📊 Changes **2 files changed** (+26 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/migrate/migrate.go` (+19 -12) 📝 `internal/cli/shared/app_info_helpers.go` (+7 -7) </details> ### 📄 Description ## Summary - Aligned character counting in `migrate` validation functions (`validateVersionLocalization`, `validateAppInfoLocalization`) with `metadata.go` by switching from `len()` (byte count) to `utf8.RuneCountInString()` (rune count) for shared metadata limits, resolving inconsistencies for multi-byte UTF-8 content. - Unexported internal helper functions `IsNonLiveAppInfoState` and `AppInfoAttrString` in `internal/cli/shared/app_info_helpers.go` to reduce the public API surface, as they are only used within their own file. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>