[PR #395] [MERGED] Require confirm for destructive removals #497

New issue

Closed

opened 2026-02-26 22:31:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/395
Author: @rudrankriyam
Created: 2/2/2026
Status: ✅ Merged
Merged: 2/2/2026
Merged by: @rudrankriyam

Base: main ← Head: fix/destructive-confirm-guards

📝 Commits (4)

a0ec804 Require confirm for destructive removals.
af5e8c1 Fix confirm flags and ignore Cursor.
86ee902 Stabilize app-setup validation tests.
1835263 Add validation tests for auth and install.

📊 Changes

11 files changed (+231 additions, -14 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 internal/cli/auth/open_url.go (+11 -0)
➕ internal/cli/auth/open_url_test.go (+21 -0)
📝 internal/cli/builds/builds.go (+8 -3)
📝 internal/cli/builds/builds_commands.go (+7 -2)
📝 internal/cli/builds/builds_individual_testers.go (+8 -3)
📝 internal/cli/cmdtest/commands_test.go (+98 -0)
📝 internal/cli/install/install.go (+15 -0)
📝 internal/cli/install/install_test.go (+46 -0)
📝 internal/cli/testflight/beta_groups.go (+8 -3)
📝 internal/cli/testflight/beta_testers.go (+8 -3)

📄 Description

Summary

require --confirm for destructive build and TestFlight removal commands
add validation tests for new confirm checks
validate install package names and auth open URLs

Test plan

Not run (not requested)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/395 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/2/2026 **Status:** ✅ Merged **Merged:** 2/2/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `fix/destructive-confirm-guards` --- ### 📝 Commits (4) - [`a0ec804`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a0ec804f56ca34e8b2e337783ffbfd4c3a664cc2) Require confirm for destructive removals. - [`af5e8c1`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/af5e8c1a97851b05e60acba23ac62ba3827eae8f) Fix confirm flags and ignore Cursor. - [`86ee902`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/86ee902249494620a20fac664052be08f84429d2) Stabilize app-setup validation tests. - [`1835263`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/18352639f2bad72f05462b42d1c115d014a3fb12) Add validation tests for auth and install. ### 📊 Changes **11 files changed** (+231 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `internal/cli/auth/open_url.go` (+11 -0) ➕ `internal/cli/auth/open_url_test.go` (+21 -0) 📝 `internal/cli/builds/builds.go` (+8 -3) 📝 `internal/cli/builds/builds_commands.go` (+7 -2) 📝 `internal/cli/builds/builds_individual_testers.go` (+8 -3) 📝 `internal/cli/cmdtest/commands_test.go` (+98 -0) 📝 `internal/cli/install/install.go` (+15 -0) 📝 `internal/cli/install/install_test.go` (+46 -0) 📝 `internal/cli/testflight/beta_groups.go` (+8 -3) 📝 `internal/cli/testflight/beta_testers.go` (+8 -3) </details> ### 📄 Description ## Summary - require `--confirm` for destructive build and TestFlight removal commands - add validation tests for new confirm checks - validate install package names and auth open URLs ## Test plan - [ ] Not run (not requested) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>