starred/App-Store-Connect-CLI
1
0
Fork 0
mirror of https://github.com/rudrankriyam/App-Store-Connect-CLI.git synced 2026-04-25 15:45:48 +03:00
Code Issues 2 Projects Releases 10 Packages Wiki Activity

[PR #463] [MERGED] fix: harden update/reporting and eliminate zero-coverage packages #544

New issue
Closed
opened 2026-02-26 22:31:27 +03:00 by kerem · 0 comments
kerem commented 2026-02-26 22:31:27 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/463
Author: @rudrankriyam
Created: 2/9/2026
Status: ✅ Merged
Merged: 2/10/2026
Merged by: @rudrankriyam

Base: main ← Head: audit/fix-security-and-test-gaps

📝 Commits (10+)

  • f83a3ba fix: harden update/reporting paths and raise CLI test coverage
  • c87c9de test: add phase 1 coverage for utility command packages
  • b3d0428 test: add phase 2 coverage for identity and metadata commands
  • d6afb74 test: add phase 3 smoke coverage for release command families
  • 69af862 test: add phase 4 coverage for commerce and operational commands
  • 03b9a96 test: add phase 5 coverage for game center and xcode cloud
  • 07a6392 test: add phase 6 main package coverage and finalize plan
  • 2971db9 test: add phase 7 behavior coverage for high-risk packages
  • d27ecd3 test: add phase 8 API interaction coverage for core CLI flows
  • badf871 test: add phase 9 negative-path API coverage for core flows

📊 Changes

105 files changed (+20915 additions, -20 deletions)

View changed files

➕ cmd/run_additional_test.go (+228 -0)
➕ internal/asc/types/resources_test.go (+70 -0)
➕ internal/cli/accessibility/accessibility_test.go (+89 -0)
➕ internal/cli/actors/actors_test.go (+60 -0)
➕ internal/cli/agerating/age_rating_test.go (+84 -0)
➕ internal/cli/agreements/agreements_test.go (+87 -0)
➕ internal/cli/androidiosmapping/android_ios_mapping_test.go (+29 -0)
➕ internal/cli/app_events/app_events_test.go (+34 -0)
➕ internal/cli/appclips/app_clips_test.go (+33 -0)
➕ internal/cli/apps/helpers_normalization_test.go (+127 -0)
➕ internal/cli/assets/assets_test.go (+27 -0)
➕ internal/cli/auth/auth_test.go (+688 -0)
➕ internal/cli/betaapplocalizations/beta_app_localizations_test.go (+23 -0)
➕ internal/cli/betabuildlocalizations/beta_build_localizations_test.go (+23 -0)
➕ internal/cli/buildbundles/build_bundles_test.go (+26 -0)
➕ internal/cli/buildlocalizations/build_localizations_test.go (+20 -0)
➕ internal/cli/builds/builds_expire_all_test.go (+143 -0)
➕ internal/cli/categories/categories_test.go (+67 -0)
➕ internal/cli/cmdtest/alternative_distribution_next_validation_test.go (+272 -0)
➕ internal/cli/cmdtest/analytics_next_validation_test.go (+288 -0)

...and 80 more files

📄 Description

Summary

  • Preserve the existing hardening changes for update/reporting paths (fail-closed checksum handling and safer JUnit report writing).
  • Add a phased coverage expansion tracked in plan.md, with package-local tests added across command families one phase at a time.
  • Cover all packages that were previously at 0.0% including large command surfaces (gamecenter, xcodecloud) and the root package (main) via testable helper seams without changing CLI behavior.
  • Bring the branch to a state where short coverage runs no longer report any package at 0.0%.

Test plan

  • make format
  • make lint
  • make test
  • go test -short -coverprofile=coverage.out ./...
  • Verify no coverage: 0.0% of statements packages remain

Phase commits

  • c87c9de phase 1 coverage
  • b3d0428 phase 2 coverage
  • d6afb74 phase 3 coverage
  • 69af862 phase 4 coverage
  • 03b9a96 phase 5 coverage
  • 07a6392 phase 6 coverage

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/463 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/9/2026 **Status:** ✅ Merged **Merged:** 2/10/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `audit/fix-security-and-test-gaps` --- ### 📝 Commits (10+) - [`f83a3ba`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/f83a3baec25cc30e18eb28ff71afcd865c544c9e) fix: harden update/reporting paths and raise CLI test coverage - [`c87c9de`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/c87c9de0bd533c30a73bb94fc837a28330cfe57b) test: add phase 1 coverage for utility command packages - [`b3d0428`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b3d042818b8732ce568628f90636b1de8dc73a09) test: add phase 2 coverage for identity and metadata commands - [`d6afb74`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d6afb7499678ed38d3002e87e57404b9cf6133ea) test: add phase 3 smoke coverage for release command families - [`69af862`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/69af8622df54f1770e747fe672319f4a36020455) test: add phase 4 coverage for commerce and operational commands - [`03b9a96`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/03b9a968020cbb06322e168f9560cb4658fecbbd) test: add phase 5 coverage for game center and xcode cloud - [`07a6392`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/07a63928937349b32a9533229024d39f0be6bf75) test: add phase 6 main package coverage and finalize plan - [`2971db9`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/2971db90a131d9ee9e539d52f7798fd9b79acc3d) test: add phase 7 behavior coverage for high-risk packages - [`d27ecd3`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d27ecd3c95c06afc51bd1e6beca1a7e22cace281) test: add phase 8 API interaction coverage for core CLI flows - [`badf871`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/badf871435e069360b63bd0ae04a6130251f7e35) test: add phase 9 negative-path API coverage for core flows ### 📊 Changes **105 files changed** (+20915 additions, -20 deletions) <details> <summary>View changed files</summary> ➕ `cmd/run_additional_test.go` (+228 -0) ➕ `internal/asc/types/resources_test.go` (+70 -0) ➕ `internal/cli/accessibility/accessibility_test.go` (+89 -0) ➕ `internal/cli/actors/actors_test.go` (+60 -0) ➕ `internal/cli/agerating/age_rating_test.go` (+84 -0) ➕ `internal/cli/agreements/agreements_test.go` (+87 -0) ➕ `internal/cli/androidiosmapping/android_ios_mapping_test.go` (+29 -0) ➕ `internal/cli/app_events/app_events_test.go` (+34 -0) ➕ `internal/cli/appclips/app_clips_test.go` (+33 -0) ➕ `internal/cli/apps/helpers_normalization_test.go` (+127 -0) ➕ `internal/cli/assets/assets_test.go` (+27 -0) ➕ `internal/cli/auth/auth_test.go` (+688 -0) ➕ `internal/cli/betaapplocalizations/beta_app_localizations_test.go` (+23 -0) ➕ `internal/cli/betabuildlocalizations/beta_build_localizations_test.go` (+23 -0) ➕ `internal/cli/buildbundles/build_bundles_test.go` (+26 -0) ➕ `internal/cli/buildlocalizations/build_localizations_test.go` (+20 -0) ➕ `internal/cli/builds/builds_expire_all_test.go` (+143 -0) ➕ `internal/cli/categories/categories_test.go` (+67 -0) ➕ `internal/cli/cmdtest/alternative_distribution_next_validation_test.go` (+272 -0) ➕ `internal/cli/cmdtest/analytics_next_validation_test.go` (+288 -0) _...and 80 more files_ </details> ### 📄 Description ## Summary - Preserve the existing hardening changes for update/reporting paths (fail-closed checksum handling and safer JUnit report writing). - Add a phased coverage expansion tracked in `plan.md`, with package-local tests added across command families one phase at a time. - Cover all packages that were previously at `0.0%` including large command surfaces (`gamecenter`, `xcodecloud`) and the root package (`main`) via testable helper seams without changing CLI behavior. - Bring the branch to a state where short coverage runs no longer report any package at `0.0%`. ## Test plan - [x] `make format` - [x] `make lint` - [x] `make test` - [x] `go test -short -coverprofile=coverage.out ./...` - [x] Verify no `coverage: 0.0% of statements` packages remain ## Phase commits - [x] `c87c9de` phase 1 coverage - [x] `b3d0428` phase 2 coverage - [x] `d6afb74` phase 3 coverage - [x] `69af862` phase 4 coverage - [x] `03b9a96` phase 5 coverage - [x] `07a6392` phase 6 coverage --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 22:31:27 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.1
1.1.0
1.0.1
1.0.0
0.49.1
0.49.0
0.48.1
0.48.0
0.47.1
0.47.0
0.46.2
0.46.1
0.46.0
0.45.4
0.45.3
0.45.2
0.45.1
0.45.0
0.44.2
0.44.1
0.44.0
0.43.0
0.42.0
0.41.4
0.41.3
0.41.2
0.41.1
0.41.0
0.40.1
0.40.0
0.39.1
0.39.0
0.38.3
0.38.2
0.38.1
0.38.0
0.37.3
0.37.2
0.37.1
0.37.0
0.36.3
0.36.2
0.36.1
0.36.0
0.35.3
0.35.2
0.35.1
0.35.0
0.34.1
0.34.0
0.33.2
0.33.1
0.33.0
0.32.0
0.31.3
0.31.2
0.31.1
0.31.0
0.30.0
0.29.3
0.29.2
0.29.1
0.29.0
0.28.14
0.28.13
0.28.12
0.28.11
0.28.10
0.28.9
0.28.8
0.28.7
0.28.6
0.28.5
0.28.4
0.28.3
0.28.2
0.28.1
0.28.0
0.27.0
0.26.4
0.26.3
0.26.2
0.26.1
0.26.0
0.25.4
0.25.3
0.25.1
0.25.0
0.24.3
0.24.2
0.24.1
0.24.0
0.23.5
0.23.4
0.23.3
0.23.2
0.23.1
0.23.0
0.22.1
0.22.0
0.21.0
0.20.2
0.20.1
0.20.0
0.19.3
0.19.2
0.19.1
0.19.0
0.18.2
0.18.1
0.18.0
0.17.0
0.16.0
0.15.0
0.14.0
0.13.0
0.12.4
0.12.3
0.12.2
0.12.1
0.12.0
0.11.0
0.10.2
0.10.1
0.10.0
0.9.0
0.8.1
0.8.0
0.7.0
0.6.0
0.5.0
0.3.1
0.3.0
0.2.0
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
Labels
Clear labels   
bug

   
bug

   
documentation

   
enhancement

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
bug
documentation
enhancement
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/App-Store-Connect-CLI#544
No description provided.