[PR #352] [MERGED] Delete result type unification #463

New issue

Closed

opened 2026-02-26 22:31:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/352
Author: @cursor[bot]
Created: 1/30/2026
Status: ✅ Merged
Merged: 1/30/2026
Merged by: @rudrankriyam

Base: cursor/subscriptions-sub-resources-parity-9e2b ← Head: cursor/delete-result-type-unification-5da0

📝 Commits (1)

1d964fc Use shared asset delete result type

📊 Changes

5 files changed (+4 additions, -8 deletions)

View changed files

📝 internal/cli/subscriptions/group_localizations.go (+1 -1)
📝 internal/cli/subscriptions/helpers.go (+0 -4)
📝 internal/cli/subscriptions/introductory_offers.go (+1 -1)
📝 internal/cli/subscriptions/localizations.go (+1 -1)
📝 internal/cli/subscriptions/promotional_offers.go (+1 -1)

📄 Description

Remove redundant deleteResult struct and use asc.AssetDeleteResult for consistency.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/352 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/30/2026 **Status:** ✅ Merged **Merged:** 1/30/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `cursor/subscriptions-sub-resources-parity-9e2b` ← **Head:** `cursor/delete-result-type-unification-5da0` --- ### 📝 Commits (1) - [`1d964fc`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/1d964fc8b5c19db60d5dcfec26648a4ed506dcd3) Use shared asset delete result type ### 📊 Changes **5 files changed** (+4 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/subscriptions/group_localizations.go` (+1 -1) 📝 `internal/cli/subscriptions/helpers.go` (+0 -4) 📝 `internal/cli/subscriptions/introductory_offers.go` (+1 -1) 📝 `internal/cli/subscriptions/localizations.go` (+1 -1) 📝 `internal/cli/subscriptions/promotional_offers.go` (+1 -1) </details> ### 📄 Description Remove redundant `deleteResult` struct and use `asc.AssetDeleteResult` for consistency. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>