[PR #416] [MERGED] TestFlight missing endpoints #510

New issue

Closed

opened 2026-02-26 22:31:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/416
Author: @rudrankriyam
Created: 2/2/2026
Status: ✅ Merged
Merged: 2/3/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/testflight-missing-endpoints-0019

📝 Commits (4)

a1ba4a8 Add testflight review submissions list and recruitment delete
916ce59 Add testflight relationship and feedback delete commands
a9a5d2f Fix indentation in recruitment subcommand list (#417)
b1efe1c Require build filter for review submissions list.

📊 Changes

20 files changed (+1612 additions, -3 deletions)

View changed files

📝 internal/asc/beta_recruitment.go (+6 -0)
📝 internal/asc/client.go (+129 -0)
📝 internal/asc/client_beta_feedback.go (+24 -0)
📝 internal/asc/client_http_test.go (+170 -0)
📝 internal/asc/client_pagination.go (+4 -0)
📝 internal/asc/output_beta.go (+113 -0)
📝 internal/asc/output_core.go (+20 -0)
📝 internal/asc/output_testflight.go (+20 -0)
📝 internal/cli/apps/apps.go (+1 -0)
➕ internal/cli/apps/apps_beta_testers.go (+73 -0)
➕ internal/cli/cmdtest/apps_remove_beta_testers_test.go (+118 -0)
📝 internal/cli/cmdtest/builds_parity_test.go (+20 -0)
📝 internal/cli/cmdtest/commands_test.go (+50 -0)
➕ internal/cli/cmdtest/testflight_beta_feedback_delete_test.go (+102 -0)
➕ internal/cli/cmdtest/testflight_beta_testers_updates_test.go (+178 -0)
➕ internal/cli/cmdtest/testflight_review_submissions_list_test.go (+135 -0)
📝 internal/cli/testflight/beta_feedback.go (+112 -2)
📝 internal/cli/testflight/beta_testers.go (+199 -0)
📝 internal/cli/testflight/testflight_review.go (+134 -1)
📝 internal/update/integration_test.go (+4 -0)

📄 Description

Implement TestFlight review submissions list, recruitment delete, and various beta feedback/tester relationship commands to expand CLI functionality.

Summary:

Wired the “easy wins” (TestFlight review submissions list + recruitment delete) and added pagination support.
Added the remaining TestFlight/app beta feedback/tester relationship commands with new output result types.
Implemented missing ASC client methods and HTTP tests, plus CLI cmdtests for flag validation and output across the new commands.

Testing:

make test
go test ./internal/cli/cmdtest -run 'TestTestFlightReviewSubmissionsListOutputTable|TestTestFlightBetaFeedbackCrashSubmissionsDeleteOutput|TestAppsRemoveBetaTestersOutput' -v

Walkthrough artifact:

testflight_cmdtests_demo_zoomed/recording_demo.mp4 shows the targeted cmdtests passing for the new review submissions list, beta feedback delete, and apps remove-beta-testers commands.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/416 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/2/2026 **Status:** ✅ Merged **Merged:** 2/3/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/testflight-missing-endpoints-0019` --- ### 📝 Commits (4) - [`a1ba4a8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a1ba4a8ee993c4edc69da238fe175ec2dc2e88e2) Add testflight review submissions list and recruitment delete - [`916ce59`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/916ce596c0f85bf01ea8cef3c336fd64c52a8684) Add testflight relationship and feedback delete commands - [`a9a5d2f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a9a5d2ff2ccb088e927195e0a5a7efc575a4cb45) Fix indentation in recruitment subcommand list (#417) - [`b1efe1c`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b1efe1cff6a2e0e32666a124b8f768d8b099076f) Require build filter for review submissions list. ### 📊 Changes **20 files changed** (+1612 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/beta_recruitment.go` (+6 -0) 📝 `internal/asc/client.go` (+129 -0) 📝 `internal/asc/client_beta_feedback.go` (+24 -0) 📝 `internal/asc/client_http_test.go` (+170 -0) 📝 `internal/asc/client_pagination.go` (+4 -0) 📝 `internal/asc/output_beta.go` (+113 -0) 📝 `internal/asc/output_core.go` (+20 -0) 📝 `internal/asc/output_testflight.go` (+20 -0) 📝 `internal/cli/apps/apps.go` (+1 -0) ➕ `internal/cli/apps/apps_beta_testers.go` (+73 -0) ➕ `internal/cli/cmdtest/apps_remove_beta_testers_test.go` (+118 -0) 📝 `internal/cli/cmdtest/builds_parity_test.go` (+20 -0) 📝 `internal/cli/cmdtest/commands_test.go` (+50 -0) ➕ `internal/cli/cmdtest/testflight_beta_feedback_delete_test.go` (+102 -0) ➕ `internal/cli/cmdtest/testflight_beta_testers_updates_test.go` (+178 -0) ➕ `internal/cli/cmdtest/testflight_review_submissions_list_test.go` (+135 -0) 📝 `internal/cli/testflight/beta_feedback.go` (+112 -2) 📝 `internal/cli/testflight/beta_testers.go` (+199 -0) 📝 `internal/cli/testflight/testflight_review.go` (+134 -1) 📝 `internal/update/integration_test.go` (+4 -0) </details> ### 📄 Description Implement TestFlight review submissions list, recruitment delete, and various beta feedback/tester relationship commands to expand CLI functionality. **Summary:** - Wired the “easy wins” (TestFlight review submissions list + recruitment delete) and added pagination support. - Added the remaining TestFlight/app beta feedback/tester relationship commands with new output result types. - Implemented missing ASC client methods and HTTP tests, plus CLI cmdtests for flag validation and output across the new commands. **Testing:** - `make test` - `go test ./internal/cli/cmdtest -run 'TestTestFlightReviewSubmissionsListOutputTable|TestTestFlightBetaFeedbackCrashSubmissionsDeleteOutput|TestAppsRemoveBetaTestersOutput' -v` **Walkthrough artifact:** - `testflight_cmdtests_demo_zoomed/recording_demo.mp4` shows the targeted cmdtests passing for the new review submissions list, beta feedback delete, and apps remove-beta-testers commands. --- <a href="https://cursor.com/background-agent?bcId=bc-d70e60d3-e343-470d-b2ff-452bb4342994"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-d70e60d3-e343-470d-b2ff-452bb4342994"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>