[PR #289] [MERGED] Add pass type ID CLI support #416

New issue

Closed

opened 2026-02-26 22:30:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:30:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/289
Author: @rudrankriyam
Created: 1/29/2026
Status: ✅ Merged
Merged: 1/29/2026
Merged by: @rudrankriyam

Base: main ← Head: feat/pass-type-ids

📝 Commits (4)

539d63b Support pass type ID management.
61ae5b1 feat: align pass type ID queries with OpenAPI
0094a7e chore: drop unsupported params for pass type cert list
7e13df4 Merge branch 'main' into feat/pass-type-ids

📊 Changes

17 files changed (+900 additions, -577 deletions)

View changed files

📝 docs/API_NOTES.md (+5 -0)
📝 internal/asc/android_ios_mapping.go (+0 -27)
📝 internal/asc/client_http_test.go (+0 -261)
📝 internal/asc/client_options.go (+59 -40)
📝 internal/asc/client_pagination.go (+2 -0)
📝 internal/asc/client_pass_type_ids.go (+40 -7)
➕ internal/asc/client_pass_type_ids_test.go (+386 -0)
📝 internal/asc/client_queries.go (+66 -56)
📝 internal/asc/client_test.go (+6 -6)
➕ internal/asc/nullable.go (+29 -0)
📝 internal/asc/output_pass_type_ids_test.go (+20 -20)
📝 internal/asc/pass_type_ids.go (+8 -2)
➕ internal/cli/cmdtest/pass_type_ids_test.go (+92 -0)
📝 internal/cli/passtypeids/certificates.go (+48 -59)
📝 internal/cli/passtypeids/pass_type_ids.go (+130 -95)
📝 internal/cli/passtypeids/shared_wrappers.go (+8 -4)
📝 internal/cli/registry/registry.go (+1 -0)

📄 Description

Summary

add pass type ID commands with certificate subcommands and validation
implement pass type ID client endpoints and relationship helpers
add output formatting and tests for pass type ID list/delete and client requests

Test Plan

make format
make test
make lint

Fixes #250

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/289 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/29/2026 **Status:** ✅ Merged **Merged:** 1/29/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feat/pass-type-ids` --- ### 📝 Commits (4) - [`539d63b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/539d63bf6c3ef816bc86a0d59e02a755edc12c7e) Support pass type ID management. - [`61ae5b1`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/61ae5b17625576a8af80c61d5c114713d8aef2b9) feat: align pass type ID queries with OpenAPI - [`0094a7e`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/0094a7e865ad1b21ba758084aed313fe1e578359) chore: drop unsupported params for pass type cert list - [`7e13df4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/7e13df40d986196d06e508097e0d021a47e45cc0) Merge branch 'main' into feat/pass-type-ids ### 📊 Changes **17 files changed** (+900 additions, -577 deletions) <details> <summary>View changed files</summary> 📝 `docs/API_NOTES.md` (+5 -0) 📝 `internal/asc/android_ios_mapping.go` (+0 -27) 📝 `internal/asc/client_http_test.go` (+0 -261) 📝 `internal/asc/client_options.go` (+59 -40) 📝 `internal/asc/client_pagination.go` (+2 -0) 📝 `internal/asc/client_pass_type_ids.go` (+40 -7) ➕ `internal/asc/client_pass_type_ids_test.go` (+386 -0) 📝 `internal/asc/client_queries.go` (+66 -56) 📝 `internal/asc/client_test.go` (+6 -6) ➕ `internal/asc/nullable.go` (+29 -0) 📝 `internal/asc/output_pass_type_ids_test.go` (+20 -20) 📝 `internal/asc/pass_type_ids.go` (+8 -2) ➕ `internal/cli/cmdtest/pass_type_ids_test.go` (+92 -0) 📝 `internal/cli/passtypeids/certificates.go` (+48 -59) 📝 `internal/cli/passtypeids/pass_type_ids.go` (+130 -95) 📝 `internal/cli/passtypeids/shared_wrappers.go` (+8 -4) 📝 `internal/cli/registry/registry.go` (+1 -0) </details> ### 📄 Description ## Summary - add pass type ID commands with certificate subcommands and validation - implement pass type ID client endpoints and relationship helpers - add output formatting and tests for pass type ID list/delete and client requests ## Test Plan - [x] make format - [x] make test - [x] make lint Fixes #250 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>