[PR #347] [MERGED] Offer codes CLI coverage #458

New issue

Closed

opened 2026-02-26 22:31:01 +03:00 by kerem · 0 comments

kerem commented 2026-02-26 22:31:01 +03:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/347
Author: @rudrankriyam
Created: 1/30/2026
Status: ✅ Merged
Merged: 1/31/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/offer-codes-cli-coverage-1166

---

📝 Commits (3)

• 8858e04 Add offer code CRUD commands and client support
• 2a6e93c Fix offer code table and markdown output
• 7604ae5 Fix offer code overlaps after subscriptions merge.

📊 Changes

16 files changed (+1705 additions, -1 deletions)

View changed files

📝 internal/asc/client_http_test.go (+200 -0)
➕ internal/asc/client_offer_codes.go (+103 -0)
📝 internal/asc/client_pagination.go (+4 -0)
📝 internal/asc/client_test.go (+52 -0)
➕ internal/asc/offer_codes_custom_output.go (+83 -0)
📝 internal/asc/offer_codes_output.go (+54 -0)
➕ internal/asc/offer_codes_subscription.go (+75 -0)
📝 internal/asc/output_core.go (+16 -0)
📝 internal/asc/output_test.go (+200 -0)
📝 internal/asc/subscription_resources.go (+3 -0)
➕ internal/cli/cmdtest/offer_codes_test.go (+107 -0)
➕ internal/cli/offercodes/custom_codes.go (+302 -0)
📝 internal/cli/offercodes/offer_codes.go (+11 -1)
➕ internal/cli/offercodes/prices.go (+113 -0)
📝 internal/cli/offercodes/shared_wrappers.go (+8 -0)
➕ internal/cli/offercodes/subscription_offer_codes.go (+374 -0)

📄 Description

Implement CRUD for subscription offer codes and custom codes, and list functionality for offer code prices to expand CLI management capabilities for subscription offers.

---

 

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/347 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/30/2026 **Status:** ✅ Merged **Merged:** 1/31/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/offer-codes-cli-coverage-1166` --- ### 📝 Commits (3) - [`8858e04`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/8858e04d8ea0ed8b626534abcff386d7b566b817) Add offer code CRUD commands and client support - [`2a6e93c`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/2a6e93c9caab2b40aef91970ca744ddb8a5f83ed) Fix offer code table and markdown output - [`7604ae5`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/7604ae5f1d6b693b3ba2b16183d3f0f4822f6467) Fix offer code overlaps after subscriptions merge. ### 📊 Changes **16 files changed** (+1705 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_http_test.go` (+200 -0) ➕ `internal/asc/client_offer_codes.go` (+103 -0) 📝 `internal/asc/client_pagination.go` (+4 -0) 📝 `internal/asc/client_test.go` (+52 -0) ➕ `internal/asc/offer_codes_custom_output.go` (+83 -0) 📝 `internal/asc/offer_codes_output.go` (+54 -0) ➕ `internal/asc/offer_codes_subscription.go` (+75 -0) 📝 `internal/asc/output_core.go` (+16 -0) 📝 `internal/asc/output_test.go` (+200 -0) 📝 `internal/asc/subscription_resources.go` (+3 -0) ➕ `internal/cli/cmdtest/offer_codes_test.go` (+107 -0) ➕ `internal/cli/offercodes/custom_codes.go` (+302 -0) 📝 `internal/cli/offercodes/offer_codes.go` (+11 -1) ➕ `internal/cli/offercodes/prices.go` (+113 -0) 📝 `internal/cli/offercodes/shared_wrappers.go` (+8 -0) ➕ `internal/cli/offercodes/subscription_offer_codes.go` (+374 -0) </details> ### 📄 Description Implement CRUD for subscription offer codes and custom codes, and list functionality for offer code prices to expand CLI management capabilities for subscription offers. --- <a href="https://cursor.com/background-agent?bcId=bc-14674fd1-cd45-4a12-b40d-487f7a0c2704"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-14674fd1-cd45-4a12-b40d-487f7a0c2704"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

kerem 2026-02-26 22:31:01 +03:00

• closed this issue
• added the
  pull-request
  label

kerem referenced this issue 2026-02-26 22:31:26 +03:00

[PR #458] [CLOSED] Command reporting and exit codes #540

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.1

1.1.0

1.0.1

1.0.0

0.49.1

0.49.0

0.48.1

0.48.0

0.47.1

0.47.0

0.46.2

0.46.1

0.46.0

0.45.4

0.45.3

0.45.2

0.45.1

0.45.0

0.44.2

0.44.1

0.44.0

0.43.0

0.42.0

0.41.4

0.41.3

0.41.2

0.41.1

0.41.0

0.40.1

0.40.0

0.39.1

0.39.0

0.38.3

0.38.2

0.38.1

0.38.0

0.37.3

0.37.2

0.37.1

0.37.0

0.36.3

0.36.2

0.36.1

0.36.0

0.35.3

0.35.2

0.35.1

0.35.0

0.34.1

0.34.0

0.33.2

0.33.1

0.33.0

0.32.0

0.31.3

0.31.2

0.31.1

0.31.0

0.30.0

0.29.3

0.29.2

0.29.1

0.29.0

0.28.14

0.28.13

0.28.12

0.28.11

0.28.10

0.28.9

0.28.8

0.28.7

0.28.6

0.28.5

0.28.4

0.28.3

0.28.2

0.28.1

0.28.0

0.27.0

0.26.4

0.26.3

0.26.2

0.26.1

0.26.0

0.25.4

0.25.3

0.25.1

0.25.0

0.24.3

0.24.2

0.24.1

0.24.0

0.23.5

0.23.4

0.23.3

0.23.2

0.23.1

0.23.0

0.22.1

0.22.0

0.21.0

0.20.2

0.20.1

0.20.0

0.19.3

0.19.2

0.19.1

0.19.0

0.18.2

0.18.1

0.18.0

0.17.0

0.16.0

0.15.0

0.14.0

0.13.0

0.12.4

0.12.3

0.12.2

0.12.1

0.12.0

0.11.0

0.10.2

0.10.1

0.10.0

0.9.0

0.8.1

0.8.0

0.7.0

0.6.0

0.5.0

0.3.1

0.3.0

0.2.0

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

Labels

Clear labels   

bug

  

bug

  

documentation

  

enhancement

  

pull-request

Mirrored from GitHub Pull Request

No labels

bug

bug

documentation

enhancement

pull-request

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/App-Store-Connect-CLI#458

No description provided.