[PR #186] [MERGED] Credential default flag reconciliation #347

New issue

Closed

opened 2026-02-26 21:34:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/186
Author: @cursor[bot]
Created: 1/26/2026
Status: ✅ Merged
Merged: 1/26/2026
Merged by: @rudrankriyam

Base: feat/auth-profiles ← Head: cursor/credential-default-flag-reconciliation-7246

📝 Commits (1)

f97921f Fix merged default credential flag

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 internal/auth/keychain.go (+6 -0)

📄 Description

Prevent multiple credentials from being marked as default when merging keychain and config credentials.

The merge logic could result in multiple IsDefault = true flags if both keychain and config sources independently marked a single credential as default, leading to incorrect display in auth status. This fix ensures that if no explicit default is configured and multiple credentials are present after merging, none are marked as default.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/186 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/26/2026 **Status:** ✅ Merged **Merged:** 1/26/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/auth-profiles` ← **Head:** `cursor/credential-default-flag-reconciliation-7246` --- ### 📝 Commits (1) - [`f97921f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/f97921f95e943b9bf79755eb90551a6490eef7e3) Fix merged default credential flag ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `internal/auth/keychain.go` (+6 -0) </details> ### 📄 Description Prevent multiple credentials from being marked as default when merging keychain and config credentials. The merge logic could result in multiple `IsDefault = true` flags if both keychain and config sources independently marked a single credential as default, leading to incorrect display in `auth status`. This fix ensures that if no explicit default is configured and multiple credentials are present after merging, none are marked as default. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>