[PR #341] [MERGED] Fix audit findings for recent CLI changes #452

New issue

Closed

opened 2026-02-26 22:31:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/341
Author: @rudrankriyam
Created: 1/30/2026
Status: ✅ Merged
Merged: 1/30/2026
Merged by: @rudrankriyam

Base: main ← Head: audit/tests

📝 Commits (4)

81d4d9d fix: harden notify slack webhook handling
d4a8050 feat: add pagination for product page media sets
9e63a59 feat: add app event media relationships
9a68a21 fix: tighten relationships pagination handling

📊 Changes

23 files changed (+970 additions, -17 deletions)

View changed files

📝 internal/asc/client_options.go (+42 -0)
📝 internal/asc/client_product_pages.go (+30 -4)
📝 internal/asc/client_product_pages_test.go (+70 -0)
📝 internal/asc/client_queries.go (+20 -0)
📝 internal/asc/output_product_pages_test.go (+48 -0)
📝 internal/asc/output_test.go (+30 -0)
📝 internal/asc/review_submissions_test.go (+32 -0)
📝 internal/cli/app_events/screenshots.go (+87 -0)
📝 internal/cli/app_events/video_clips.go (+87 -0)
📝 internal/cli/cmdtest/app_events_test.go (+20 -0)
📝 internal/cli/cmdtest/notify_test.go (+3 -1)
📝 internal/cli/cmdtest/product_pages_test.go (+132 -0)
📝 internal/cli/notify/notify.go (+74 -5)
📝 internal/cli/notify/notify_test.go (+74 -1)
📝 internal/cli/productpages/custom_page_localization_media_sets.go (+66 -4)
📝 internal/cli/profiles/profiles_test.go (+18 -0)
📝 internal/cli/profiles/relationships.go (+38 -0)
📝 internal/cli/registry/registry.go (+0 -1)
📝 internal/cli/users/users_test.go (+18 -0)
📝 internal/cli/users/visible_apps.go (+38 -0)

...and 3 more files

📄 Description

Summary

harden notify slack webhook handling with URL validation, timeouts, and safer errors
add pagination support for product page localization media sets and expand tests
add top-level app event media relationship commands plus missing output/review/tests
tighten relationships pagination --next handling and remove duplicate pass-type-ids registration

Test plan

ASC_APP_ID= go test ./internal/asc ./internal/cli/notify ./internal/cli/productpages ./internal/cli/app_events ./internal/cli/profiles ./internal/cli/users ./internal/cli/webhooks ./internal/cli/cmdtest

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/341 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/30/2026 **Status:** ✅ Merged **Merged:** 1/30/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `audit/tests` --- ### 📝 Commits (4) - [`81d4d9d`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/81d4d9dcb63881effc4bab82a9b8214b4e40d9d9) fix: harden notify slack webhook handling - [`d4a8050`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d4a8050c67e0c3f48adb75c5ee94678ff7d02c42) feat: add pagination for product page media sets - [`9e63a59`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/9e63a59c7990fd3208be922961ccb2925dcf827b) feat: add app event media relationships - [`9a68a21`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/9a68a21ffbb9b3cbd032716302c5f77ffbc82f8e) fix: tighten relationships pagination handling ### 📊 Changes **23 files changed** (+970 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_options.go` (+42 -0) 📝 `internal/asc/client_product_pages.go` (+30 -4) 📝 `internal/asc/client_product_pages_test.go` (+70 -0) 📝 `internal/asc/client_queries.go` (+20 -0) 📝 `internal/asc/output_product_pages_test.go` (+48 -0) 📝 `internal/asc/output_test.go` (+30 -0) 📝 `internal/asc/review_submissions_test.go` (+32 -0) 📝 `internal/cli/app_events/screenshots.go` (+87 -0) 📝 `internal/cli/app_events/video_clips.go` (+87 -0) 📝 `internal/cli/cmdtest/app_events_test.go` (+20 -0) 📝 `internal/cli/cmdtest/notify_test.go` (+3 -1) 📝 `internal/cli/cmdtest/product_pages_test.go` (+132 -0) 📝 `internal/cli/notify/notify.go` (+74 -5) 📝 `internal/cli/notify/notify_test.go` (+74 -1) 📝 `internal/cli/productpages/custom_page_localization_media_sets.go` (+66 -4) 📝 `internal/cli/profiles/profiles_test.go` (+18 -0) 📝 `internal/cli/profiles/relationships.go` (+38 -0) 📝 `internal/cli/registry/registry.go` (+0 -1) 📝 `internal/cli/users/users_test.go` (+18 -0) 📝 `internal/cli/users/visible_apps.go` (+38 -0) _...and 3 more files_ </details> ### 📄 Description ## Summary - harden `notify slack` webhook handling with URL validation, timeouts, and safer errors - add pagination support for product page localization media sets and expand tests - add top-level app event media relationship commands plus missing output/review/tests - tighten relationships pagination `--next` handling and remove duplicate pass-type-ids registration ## Test plan - [x] `ASC_APP_ID= go test ./internal/asc ./internal/cli/notify ./internal/cli/productpages ./internal/cli/app_events ./internal/cli/profiles ./internal/cli/users ./internal/cli/webhooks ./internal/cli/cmdtest` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>