[PR #303] [MERGED] Background assets pagination utilities #428

New issue

Closed

opened 2026-02-26 22:30:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:30:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/303
Author: @cursor[bot]
Created: 1/29/2026
Status: ✅ Merged
Merged: 1/29/2026
Merged by: @rudrankriyam

Base: issue/242-background-assets ← Head: cursor/background-assets-pagination-utilities-feea

📝 Commits (1)

dca3120 Add background assets pagination support

📊 Changes

1 file changed (+12 additions, -0 deletions)

View changed files

📝 internal/asc/client_pagination.go (+12 -0)

📄 Description

Enable pagination for background asset list commands by adding their response types to the PaginateAll function.

The PaginateAll function in internal/asc/client_pagination.go determines how to aggregate paginated results using a type switch. The new BackgroundAssetsResponse, BackgroundAssetVersionsResponse, and BackgroundAssetUploadFilesResponse types were missing from this switch, causing all background asset list commands using the --paginate flag to fail with an "unsupported response type for pagination" error. This change adds the necessary cases to support these types.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/303 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/29/2026 **Status:** ✅ Merged **Merged:** 1/29/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `issue/242-background-assets` ← **Head:** `cursor/background-assets-pagination-utilities-feea` --- ### 📝 Commits (1) - [`dca3120`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/dca3120e0d59df1e5b53f62b99c1409688fefb22) Add background assets pagination support ### 📊 Changes **1 file changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_pagination.go` (+12 -0) </details> ### 📄 Description Enable pagination for background asset list commands by adding their response types to the `PaginateAll` function. The `PaginateAll` function in `internal/asc/client_pagination.go` determines how to aggregate paginated results using a type switch. The new `BackgroundAssetsResponse`, `BackgroundAssetVersionsResponse`, and `BackgroundAssetUploadFilesResponse` types were missing from this switch, causing all background asset list commands using the `--paginate` flag to fail with an "unsupported response type for pagination" error. This change adds the necessary cases to support these types. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>